mirror of
https://github.com/Combodo/iTop.git
synced 2026-02-13 07:24:13 +01:00
bf1b2a5104
# Conflicts: # .doc/README.md # .doc/phpdoc-templates/combodo-wiki/graphs/class.html.twig # composer.lock # lib/composer/InstalledVersions.php # lib/composer/autoload_classmap.php # lib/composer/autoload_psr4.php # lib/composer/autoload_static.php # lib/composer/installed.json # lib/composer/installed.php # lib/symfony/cache/Traits/Relay/MoveTrait.php # lib/symfony/http-foundation/Request.php # lib/symfony/runtime/SymfonyRuntime.php
JS for iTop
File location
In order to better separate our developments from the embedded third-party libs, files should be moved in either the /js/components, /lib, /node_modules folders.
IMPORTANT: Before moving a file, we should first consider if:
- The file is used in an iTop extension that should be compatible with the iTop version currently under developments
- The file is still used in iTop itself (or if we can consider removing it for clean up)
Leading semicolon
When concataining 2 files with code execution, we might have a prb.
For example :
// file A
(A)()
// file B
(B)()
Having (A)()(B)() is different than (A)();(B)(); !
To avoid those problems simply add a leading semicolon on all JS files.