Commit Graph

15 Commits

Author SHA1 Message Date
Pierre Goiffon
776f32dbe1 🎨 Block ID generation : less risk of id collision
Reported by NonSecureUniqidUsageInspection : when calling \uniqid we should provide true as second parameter.

But was causing issues as the generated string could contain a dot, and this is used in CSS and JQuery selectors (for example a "my.id" cannot be used in #my.id selector)

So we're just replacing dots with hyphens !

Was discussed with @Molkobain in 0119f6c395
2020-10-27 16:58:25 +01:00
Pierre Goiffon
6df74073a7 🐛 Fix \Combodo\iTop\Application\UI\UIBlock::GenerateId 2020-10-27 08:42:25 +01:00
Pierre Goiffon
0119f6c395 UiBlock : fix typo + inspections 2020-10-21 19:08:17 +02:00
Molkobain
b15ed80732 Internal: Replace references to iTop 2.8.0 with iTop 3.0.0 2020-10-14 10:16:49 +02:00
Molkobain
57fda98981 Reformat code 2020-10-01 17:33:24 +02:00
Molkobain
ce001a8097 N°2847 - Rework on iUIContentBlock and PageContent
* Add new Trait tUIContentAreas to handle multiple content areas across UIBlock classes (extracted from PageContent)
* Remove return type hinting in some method when type was "self" or the class itself when it's meant to be overloaded (works only with PHP 7.4+)
* Update some PHPDoc
* Reformat some brackets
2020-10-01 17:33:24 +02:00
Eric
9cd719ab56 N°2847 - Separate inline scripts and css from html in the rendering of pages 2020-09-18 18:16:09 +02:00
Eric
410a637598 N°2847 - Tab Management - iTop Pages refactoring - introduction of UIContentBlock as base block 2020-09-16 12:00:48 +02:00
Eric
63f8ec594c N°2847 - Refactor Web Pages classes - Add UIBlockManager to the WebPage 2020-09-09 18:10:06 +02:00
Molkobain
825c70c001 Introduce type hinting in methods prototype (PHP >= 7.1) 2020-08-26 21:22:39 +02:00
Molkobain
b5c97e35bf Add visibility to class constants (PHP >= 7.1) 2020-08-26 19:02:53 +02:00
Molkobain
fa406c1f17 PHPDoc & code cleanup 2020-08-26 17:45:22 +02:00
Molkobain
5320f69c44 PHPDoc & code cleanup 2020-08-26 16:03:32 +02:00
Molkobain
ef844c396e N°2847 - Add UIBlock::GetBlockCode() method to get the code within a TWIG no matter the object class (easier than calling the right class constant) 2020-08-13 14:08:54 +02:00
Molkobain
1f0211b45a N°2847 - Rework iTopWebPage layout (WIP Part VI)
- iTopWebPage: Restore "open search" feature
- iTopWebPage: Change all resources URL to absolute in order to benefit from the "duplicate removal" benefits
- iTopWebPage: Remove obsolete method IsMenuPaneVisible()
- Config: Add new parameters quick_create.enabled / global_search.enabled / breadcrumb.enabled
- utils: Add new GetAppRevisionNumber() method
- Introduce iUIBlock interface for UI layouts, components, ...
- Introduce BlockRenderer to properly render blocks
- Add "render_block" function to TwigHelper to render blocks directly from TWIG
- Refactor layouts and components into proper block classes to fit the new architecture
2020-07-30 15:22:17 +02:00