BGdu38
c2f5cafaf3
Avoid setting memory_limit to lower value than the one already configured ( #215 )
...
Some scripts are setting the memory_limit PHP option : setup, csvimport and XLSX export. This was done to avoid crashing when dealing with such large amount of data.
But sometimes we were setting the value without any prior check, so we could actually lower the memory_limit value :/
Now this memory_limit change is done using \utils::SetMinMemoryLimit, which will call ini_set if and only if the current value is lower than the one to be set.
Setup calls (setup/ajax.dataloader.php and webservices/backoffice.dataloader.php) were left as is as they weren't subject to this bug, and also they are more complex (logging done on each case).
2021-05-25 12:03:19 +02:00
bruno-ds
0b95220d1b
N°3466 - Add (missing) translations
2021-02-16 09:46:04 +01:00
Pierre Goiffon
1304e2eb2d
N°3416 Updates after code review v2 :)
2020-12-04 08:51:07 +01:00
Pierre Goiffon
cece15d10c
N°3416 Updates after code review
...
Many thanks @bruno-ds !
* add comments to explain intentions
* fix indentations
2020-12-03 17:45:44 +01:00
Pierre Goiffon
ecebe4ecd5
N°3416 XFrame and cache headers optimizations
...
* Remove XFrame header set in \WebPage::no_cache : not this method responsability, was confusing :/
* Remove no_cache() calls when already set in page constructor (ajax_page mainly)
* Also calls everywhere the \WebPage::no_cache method instead of setting headers manually
2020-12-02 17:19:05 +01:00
Pierre Goiffon
8bfcb14d0c
N°3416 XFrame-Options header is now set using a config parameter, defaults to SAMEORIGIN
...
Also adds an indirection (\WebPage::add_xframe_options) to set header
2020-12-02 17:17:11 +01:00
Pierre Goiffon
35d77ff642
N°3416 Fix DocumentFile preview not working anymore
...
Was caused by X-Frame-Options http header added with N°3317
2020-12-02 15:44:58 +01:00
Eric
eebc29d2bb
N°3111 - Fix Portal export
...
(cherry picked from commit d3b57c3bda )
2020-10-30 14:16:57 +01:00
acognet
96332b7885
N°3139 - import csv : hyperlink not clickable
2020-10-16 14:15:51 +02:00
Pierre Goiffon
a765eb8725
Merge remote-tracking branch 'origin/support/2.6' into support/2.7
...
# Conflicts:
# application/ajaxwebpage.class.inc.php
# application/csvpage.class.inc.php
2020-10-05 16:12:49 +02:00
Pierre Goiffon
1551694198
N°3317 Security hardening
2020-10-05 14:42:03 +02:00
Eric
0cc5dc0471
N°3317 - Add http headers
2020-09-30 10:18:44 +02:00
Eric
bef1832ac7
N°3317 - Add http headers
2020-09-29 14:07:24 +02:00
odain
4e0eed6e13
N°3270 Notify on expiration not sending notification (trigger exception)
...
add boilerplate function and use it to intercept/enrich trigger exception loops
2020-09-25 07:18:14 +02:00
Eric
1453558f3e
N°3317 - Add http headers
2020-09-22 11:39:19 +02:00
Eric
dbada2f72a
N°3238 - Fix multi-words search in FilterBrick and ManageBrick
2020-09-04 17:34:59 +02:00
acognet
f774a90b7e
N°3146 - Affichage des class user dans l'import CSV
2020-08-31 17:15:59 +02:00
Eric
5b04143711
N°3111 - Fix Portal export
2020-07-21 16:39:55 +02:00
Pierre Goiffon
0d1059a8fc
Merge remote-tracking branch 'origin/support/2.6' into support/2.7
...
# Conflicts:
# application/utils.inc.php
# conf/web.config
# datamodels/2.x/itop-backup/ajax.backup.php
# datamodels/2.x/itop-backup/status.php
2020-05-18 09:24:46 +02:00
Eric
fa3610cfee
N°2641 - Create a dedicated ErrorPage for fatal errors
...
Fix fatal errors being logged in setup.log instead of error.log
2020-05-14 14:37:38 +02:00
acognet
150d3e096d
N°2346 - Function GetTrackOrigin() doesn't return good value during csvimport
2020-05-13 23:55:26 +02:00
bruno DA SILVA
839bbc425f
N°2901 Add log to help diagnose lost InlineImage
...
they are disabled by default, use this to enable:
```
'log_level_min' => array(
'InlineImage' => LogAPI::LEVEL_TRACE,
'UserRequest' => LogAPI::LEVEL_TRACE,
),
```
2020-05-12 15:34:13 +02:00
acognet
873d109b98
N°1910 - iTop - Search on Text contains "_" not working - move correction in other place
2020-05-12 14:48:16 +02:00
Eric
a81950571a
N°1598 - Fix regression on modify
2020-05-12 14:21:34 +02:00
Eric
0342b89481
N°1598 - warning for bad stimulus instead of fatal error
2020-05-12 11:01:04 +02:00
Pierre Goiffon
3c9318d56a
N°2990 Fix count warning on audit OQL error
2020-05-12 09:41:24 +02:00
Pierre Goiffon
30d10b6f11
N°2990 Security hardening
2020-05-12 09:40:58 +02:00
bruno DA SILVA
7a40db94fb
2424 - Better messages when an object update fail & removed an unwanted webserver error log entry
2020-05-04 12:00:30 +02:00
Pierre Goiffon
9b065ffb0a
Merge remote-tracking branch 'origin/support/2.7.0' into support/2.7
...
# Conflicts:
# datamodels/2.x/itop-attachments/renderers.itop-attachments.php
2020-04-29 09:00:10 +02:00
Pierre Goiffon
db593ff85e
Merge remote-tracking branch 'origin/support/2.6' into support/2.7
...
# Conflicts:
# application/loginwebpage.class.inc.php
# application/menunode.class.inc.php
# datamodels/2.x/itop-portal-base/portal/src/controllers/aggregatepagebrickcontroller.class.inc.php
# datamodels/2.x/itop-portal-base/portal/src/controllers/userprofilebrickcontroller.class.inc.php
# datamodels/2.x/itop-portal-base/portal/src/views/bricks/manage/popup-export-excel.html.twig
# pages/ajax.render.php
2020-04-20 16:05:56 +02:00
Pierre Goiffon
4ee66377ce
Merge commit '15e5e21a89a3d3214dace82b8765a47e304a8f29' into support/2.7
2020-04-20 14:21:55 +02:00
acognet
bbc751bee4
N°2383 - GetAttributeFlag ignored on form refresh with dependent field
2020-04-14 17:56:27 +02:00
Eric
5b60ec9edf
N°2919 - Dashboard - Fix dashboard not saved
...
the sanitization was too strong. Some names can contain ':'
2020-04-10 18:11:36 +02:00
Eric
b88b9dabdb
N°2919 - Dashboard - Fix dashboard not saved
...
The sanitization was too strong. Some names can contain ':'
2020-04-09 17:59:52 +02:00
Stephen Abello
4b7f736af0
N°2755 - Security hardening
2020-04-06 09:42:41 +02:00
Stephen Abello
016fbaed36
N°2755 - Security hardening
2020-04-06 09:42:15 +02:00
Stephen Abello
bfcd137e52
N°2853 - Security hardening
...
(cherry picked from commit d01caaf4e4 )
2020-04-06 09:37:58 +02:00
Molkobain
986eb90546
N°2893 - Fix DataModel Viewer not supporting special chars in class name (eg. ")
2020-03-31 09:40:31 +02:00
acognet
fc7b772ba3
N°1910 - iTop - Search on Text contains "_" not working
...
_ is a special caracter in mysql -> replace with \_
2020-03-30 16:13:47 +02:00
Molkobain
4f7676c42d
N°2735 - Rollback previous "fixes" to keep the simple ID policy in the Designer and a unique ID generation at runtime
2020-03-16 12:17:09 +01:00
Molkobain
29d963317f
N°2735 - Fix dashlet ID generation to have the "CUSTOM" prefix only at runtime
2020-03-12 16:46:15 +01:00
Molkobain
bbfddea93d
Open new_dashlet_id operation for Designer
2020-03-12 14:16:02 +01:00
Stephen Abello
d01caaf4e4
N°2853 - Security hardening
2020-03-10 10:23:38 +01:00
Molkobain
e2a3e0e74f
N°2735 - Continue rework of the dashlet id generation:
...
- Move generation from DashboardLayout to Dashboard
- Migrate dashlet user preference in RuntimeDashboard only (and not in DesignTimeDashboard)
2020-02-26 16:29:32 +01:00
Molkobain
5a01a76f80
N°2735 - Add new sanitize filter ('element_identifier') for dashboard identifier
2020-02-26 12:10:18 +01:00
Pierre Goiffon
dfc894f6fd
N°2735 Fix cannot edit new dashlet properties regression
...
Was introduced by cf83bc73
2020-02-25 11:17:52 +01:00
Pierre Goiffon
a92157f763
N°2790 fix collapsibleLabel
...
* change icon when label closed
* fix switch in about dialog for licenses details
2020-02-18 16:34:51 +01:00
Pierre Goiffon
cf83bc7364
N°2634 / N°2735 Fix dashlets identifiers : was causing prb on widget init, prefs save
...
Dashlet id now includes :
* "CUSTOM-" if dashlet is contained in a custom dashboard, nothing elsewhere
* the ID of the dashboard
- for menus : menu id escaped for HTML
- for AttributeDashboard : <class>__<field>
* the row / cell / dashlet idx
Examples :
CUSTOM-UserRequestOverview_IDrow1-col0-0
Organization__overview_IDrow1-col0-12
2020-02-14 15:59:09 +01:00
Eric
76982a2846
Revert Last change. The values are already protected at this stage.
2020-02-14 15:42:05 +01:00
Eric
6f04525cdf
🎨 cleanup code
2020-02-13 09:49:58 +01:00