Molkobain
6aa9aa2831
N°5608 - Fix unit tests following restructuring Part I
2023-01-10 18:15:53 +01:00
Eric Espie
9b47ee12e7
N°4307 - Replace SwiftMailer by laminas-mail - Fix connecting to server without password
2023-01-10 17:58:03 +01:00
Molkobain
d177ee4a7f
Merge remote-tracking branch 'origin/support/2.7' into support/3.0
...
# Conflicts:
# tests/manual-visual-tests/Backoffice/RenderAllUiBlocks.php
# tests/php-unit-tests/ItopDataTestCase.php
# tests/php-unit-tests/ItopTestCase.php
# tests/php-unit-tests/integration-tests/dictionaries-test/fr.dictionary.itop.core.KO.wrong_php
# tests/php-unit-tests/integration-tests/dictionaries-test/fr.dictionary.itop.core.OK.php
# tests/php-unit-tests/integration-tests/iTopModulesPhpVersionChecklistTest.php
# tests/php-unit-tests/integration-tests/iTopXmlVersionChecklistTest.php
# tests/php-unit-tests/phpunit.xml.dist
# tests/php-unit-tests/unitary-tests/application/SCSSCompilationTest.php
# tests/php-unit-tests/unitary-tests/application/Session/SessionTest.php
# tests/php-unit-tests/unitary-tests/application/ThemeHandlerTest.php
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/DO_NOT_CHANGE.css-variables.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/DO_NOT_CHANGE.light-grey.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/README.md
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/_included_file3.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/cross_reference1.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/cross_reference2.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/feature1/_feature1.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/included_file1.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/included_scss/included_file2.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/included_scss/included_file4.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/multi_imports.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/shortcut.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/shortcut2.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/simple_import.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/simple_import2.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/typography.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/css/ui-lightness/DO_NOT_CHANGE.jqueryui.scss
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/css/ui-lightness/images/ui-bg_diagonals-thick_18_b81900_40x40.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/css/ui-lightness/images/ui-bg_diagonals-thick_20_666666_40x40.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/css/ui-lightness/images/ui-icons_1c94c4_256x240.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/css/ui-lightness/images/ui-icons_222222_256x240.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/css/ui-lightness/images/ui-icons_E87C1E_256x240.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/css/ui-lightness/images/ui-icons_F26522_256x240.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/css/ui-lightness/images/ui-icons_ffd27a_256x240.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/css/ui-lightness/images/ui-icons_ffffff_256x240.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/ac-background.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/actions_right.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/bg.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/breadcrumb-separator.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/calendar.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/delete.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/desc.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/error.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/eye-closed-555.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/eye-closed-fff.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/eye-open-555.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/eye-open-fff.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/full-screen.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/green-header.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/green-square.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/indicator.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/info-mini.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/minus.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/ok.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/orange-header.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/plus.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/red-header.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/truncated.png
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/tv-collapsable-last.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/tv-collapsable.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/tv-expandable-last.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/tv-expandable.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/tv-item-last.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/testimages/images/tv-item.gif
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/themes/basque-red/main.css
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/themes/basque-red/main_imagemodified.css
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/themes/basque-red/main_importmodified.css
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/themes/basque-red/main_stylesheet.css
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/themes/basque-red/main_testcompilethemes.css
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/themes/basque-red/main_varchanged.css
# tests/php-unit-tests/unitary-tests/application/theme-handler/expected/themes/basque-red/theme-parameters.json
# tests/php-unit-tests/unitary-tests/application/theme-handler/getimages/expected-getimages.json
# tests/php-unit-tests/unitary-tests/application/theme-handler/getimages/test-getimages.scss
# tests/php-unit-tests/unitary-tests/core/ActionEmailTest.php
# tests/php-unit-tests/unitary-tests/core/AttributeDefTest.inc.php
# tests/php-unit-tests/unitary-tests/core/AttributeURLDefaultPattern.php
# tests/php-unit-tests/unitary-tests/core/AttributeURLTest.php
# tests/php-unit-tests/unitary-tests/core/BulkChangeTest.inc.php
# tests/php-unit-tests/unitary-tests/core/CSVParserTest.php
# tests/php-unit-tests/unitary-tests/core/DBObjectTest.php
# tests/php-unit-tests/unitary-tests/core/DBSearchAddConditionPointingTo.php
# tests/php-unit-tests/unitary-tests/core/ExpressionEvaluateTest.php
# tests/php-unit-tests/unitary-tests/core/GetSelectFilterTest.php
# tests/php-unit-tests/unitary-tests/core/InlineImageTest.php
# tests/php-unit-tests/unitary-tests/core/Log/ExceptionLogTest.php
# tests/php-unit-tests/unitary-tests/core/Log/ExceptionLogTest/Exceptions.php
# tests/php-unit-tests/unitary-tests/core/Log/LogAPITest.php
# tests/php-unit-tests/unitary-tests/core/Log/LogFileNameBuilderTest.php
# tests/php-unit-tests/unitary-tests/core/LogAPITest.php
# tests/php-unit-tests/unitary-tests/core/LogFileNameBuilderTest.php
# tests/php-unit-tests/unitary-tests/core/MetaModelTest.php
# tests/php-unit-tests/unitary-tests/core/OQLTest.php
# tests/php-unit-tests/unitary-tests/core/UniquenessConstraintTest.php
# tests/php-unit-tests/unitary-tests/core/XMLDataLoaderTest.php
# tests/php-unit-tests/unitary-tests/core/dictApcuTest.php
# tests/php-unit-tests/unitary-tests/core/dictTest.php
# tests/php-unit-tests/unitary-tests/core/ormCaseLogTest.php
# tests/php-unit-tests/unitary-tests/core/ormPasswordTest.php
# tests/php-unit-tests/unitary-tests/core/ormStyleTest.php
# tests/php-unit-tests/unitary-tests/setup/MFCompilerTest.php
# tests/php-unit-tests/unitary-tests/setup/SubMFCompiler.php
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/1.7_to_1.6.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/1.7_to_1.6.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/1.6_to_1.7_2.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/1.6_to_1.7_2.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/1.7.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/1.7_to_1.6.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/1.7_to_1.6.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/1.7_to_1.6_2.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/1.7_to_1.6_2.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/1.7_to_3.0.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/1.7_to_3.0.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/3.0_to_1.7.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/3.0_to_1.7.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/Bug_4569.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/Convert-samples/Bug_4569.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_deleted_to_deleted.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_deleted_to_deleted.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_deleted_to_in-definition.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_deleted_to_in-definition.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_deleted_to_not-in-definition.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_deleted_to_not-in-definition.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_in-definition_to_deleted.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_in-definition_to_deleted.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_in-definition_to_in-definition.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_in-definition_to_in-definition.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_in-definition_to_not-in-definition.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_in-definition_to_not-in-definition.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_not-in-definition_to_deleted.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_not-in-definition_to_deleted.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_not-in-definition_to_in-definition.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_not-in-definition_to_in-definition.input.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_not-in-definition_to_not-in-definition.expected.xml
# tests/php-unit-tests/unitary-tests/setup/iTopDesignFormat/MoveNode-samples/from_not-in-definition_to_not-in-definition.input.xml
# tests/php-unit-tests/unitary-tests/setup/ressources/datamodels/datamodel-branding.xml
# tests/php-unit-tests/unitary-tests/sources/application/Helper/WebResourcesHelperTest.php
# tests/php-unit-tests/unitary-tests/sources/application/status/StatusIncTest.php
# tests/php-unit-tests/unitary-tests/sources/application/status/status.php
# tests/php-unit-tests/unitary-tests/synchro/DataSynchroTest.php
2023-01-10 15:27:44 +01:00
Lars Kaltefleiter
b354058eb5
N°5622 Fix backup cannot be done if TLS enabled with no CA ( #354 )
2023-01-10 12:13:33 +01:00
Molkobain
fbc0a898ae
N°5608 - Move test files to corresponding directories after branch rebase
2023-01-10 12:11:12 +01:00
Molkobain
36f8e58e25
N°5608 - Use new ItopTestCase::RequireOnceXXX in unit tests
2023-01-10 12:11:12 +01:00
Molkobain
6a7dbb06b0
N°5608 - Add methods to require_once an iTop or a unit test file to avoid crashes when tests dir is moved
2023-01-10 12:11:12 +01:00
Pierre Goiffon
43dd0b7df8
N°2013 Fix regression when installing from scratch
...
Error was "Call to a member function UpdateFromParams() on null"
Regression introduced by 15d3201a
2023-01-10 10:56:21 +01:00
Pierre Goiffon
43d86ad8e2
N°2013 Setup : fix crash on setting readonly mode if initial DB info were wrong
...
Same as 15d3201a#351 .
This fix introduces the new method \WizardController::GetParamForConfigArray
I replaced existing duplicate code with a call to this new generic method.
2023-01-10 10:56:21 +01:00
Eric Espie
d3d89b1ee2
N°5857 Fix PHPUnitPrettyPrint with PHPUnit 9
2023-01-10 09:42:13 +01:00
Pierre Goiffon
15d3201a40
N°2013 Setup : fix crash on compilation if initial DB info were wrong
...
Use case :
- having in the iTop config file wrong DB parameters (unreachable server for example)
- launch the setup in update mode
- fix the DB config in the wizard
The PR #351 solved the errors that were happening in the following steps.
But we still had an error during compilation, caused by the maintenance mode activation.
2023-01-09 16:11:27 +01:00
Eric Espie
cf4616d9a1
N°4756 - Ease extensibility for CRUD operations : Unit tests
2023-01-09 13:59:55 +01:00
Molkobain
5721a324c1
Tests: Always display test status for better feedback
2023-01-06 22:30:09 +01:00
Molkobain
7de6c72154
Tests: Rename provider method name to match convention
2023-01-06 22:30:09 +01:00
Molkobain
c0cee02351
N°5608 - Factorize all core modules tests to a single test suite
2023-01-06 22:30:09 +01:00
Molkobain
bb674fb873
N°5608 - Move/rename "status" unit tests to match their counterpart location/name
2023-01-06 22:30:09 +01:00
Molkobain
6136eadd31
N°5608 - Fix some broken require paths since move/rename
2023-01-06 22:30:08 +01:00
Molkobain
87cb73c038
N°5608 - Rename "test" folder to "tests" to better match conventions
2023-01-06 22:30:08 +01:00
Molkobain
11d8547cef
N°5608 - Move/rename unit tests to match their counterpart location/name
2023-01-06 22:30:08 +01:00
Molkobain
0998c73a1a
N°5608 - Add README files
2023-01-06 22:30:07 +01:00
Molkobain
471f66649a
N°5608 - Rename unitary test folders for better understanding
2023-01-06 22:30:07 +01:00
Molkobain
e8bf9cf688
N°5608 - Move "twig" PHP unit test to new folder
...
Notice: Test was not working, still not working
2023-01-06 22:30:07 +01:00
Molkobain
4f88a0e7d2
N°5608 - Move legacy PHP unit tests (not run by CI) to a dedicated folder
2023-01-06 22:30:07 +01:00
Molkobain
c6b0e273e6
N°5608 - Rename "VisualTests" folder to match new convention
2023-01-06 22:30:07 +01:00
Molkobain
d9539f9d01
N°5608 - Add comments to main autoloader
2023-01-06 22:30:06 +01:00
Molkobain
a3e309acb5
N°5608 - Revert "authent-local" test suite to its original rank as it is crashing the CI 🤔
2023-01-06 22:30:06 +01:00
Molkobain
c06cbfd4a9
N°5608 - Rename "coreExtensions" test suite to correct datamodel module (authent-local)
2023-01-06 22:30:06 +01:00
Molkobain
1d7e4e1a42
N°5608 - Move unit tests to a dedicated folder and start reorganizing to match iTop folder structure
2023-01-06 22:30:06 +01:00
Molkobain
083d19c688
📝 PHPDoc
2023-01-05 21:19:56 +01:00
Eric Espie
4e9a34d8d8
Merge branch 'support/3.0' into develop
2023-01-05 09:25:11 +01:00
Eric Espie
524e65a29b
📝 fix PHPDoc
2023-01-05 09:23:48 +01:00
Pierre Goiffon
25048ba0cc
N°3200 🎨 Replace !empty() by \utils::IsNotNullOrEmptyString
...
Thanks Molkobain !
2023-01-05 09:07:13 +01:00
Pierre Goiffon
4f7a1ea9da
N°3200 Datatable "filter list" icon : specific query for 1,n and n,n objects relations
...
This specific query passes attcodes list to display to UI.php, but this endpoint doesn't handle it yet. Adding this enhancements would require too much time for now (datatables legacy code), hopefully a refactoring work will be done soon and we'll get back to it !
Note that dedicated ContextTag is renamed from Search to ObjectSearch
2023-01-04 16:23:52 +01:00
Pierre Goiffon
a62a373f64
N°3200 ♻️ Refactor relations attcode list generation
...
The existing code was added in N°2334
Its generic part is now callable in the MetaModel::GetAttributeLinkedSetIndirectDatatableAttCodesToDisplay method
2023-01-04 16:23:52 +01:00
Pierre Goiffon
6b23171d65
N°3200 New "Filter list" icon in datatables
...
Every datatables will open its query in a new UI.php?operation=search page
2023-01-04 16:23:52 +01:00
Pierre Goiffon
09b69728a0
📝 Version history : highlight for major versions
2023-01-04 14:24:27 +01:00
Pierre Goiffon
bc0dbc7860
📝 Version history : add link to versions details on the wiki
2023-01-04 14:20:34 +01:00
Eric Espie
a693c343e8
N°4756 - Ease extensibility for CRUD operations : Reduce events after review
2023-01-04 14:18:01 +01:00
Eric Espie
cd17eb484a
N°4756 - Ease extensibility for CRUD operations : Reduce events after review
2023-01-04 12:23:23 +01:00
Vincent Dumas
259eb60f97
N°5841 - Non-admin managing User can't see Administrator by default ( #383 )
2023-01-03 14:08:28 +01:00
Eric Espie
1afa3e2003
Merge branch 'support/3.0' into develop
2023-01-03 08:52:10 +01:00
Eric Espie
df7d7c877d
N°5490 - PHP 8.0: Fix crash of bulk modify
2023-01-03 08:50:18 +01:00
Eric Espie
4c4d7c12e8
N°4756 - Ease extensibility for CRUD operations : Coherency in method parameters
2023-01-02 14:23:36 +01:00
Eric Espie
97c3cacfaa
N°4756 - Ease extensibility for CRUD operations : Pass DeletionPlan to EVENT_DB_CHECK_TO_DELETE
2023-01-02 14:20:17 +01:00
Eric Espie
98ec568788
N°4756 - Ease extensibility for CRUD operations : Events not sent in overridable methods
2023-01-02 14:06:02 +01:00
Eric Espie
626ba7ee66
📝 PHPDoc reworked packages
2022-12-30 14:17:57 +01:00
Eric Espie
3920f84f45
📝 PHPDoc reworked for auto-doc
2022-12-30 10:11:11 +01:00
Eric Espie
30d2557342
Merge branch 'support/3.0' into develop
2022-12-29 16:00:23 +01:00
Eric Espie
4bcad431aa
📝 Change packages for auto-documentation
2022-12-29 15:59:59 +01:00
Eric Espie
f3cea730af
Merge branch 'support/3.0' into develop
...
# Conflicts:
# application/applicationextension.inc.php
2022-12-29 14:40:26 +01:00
