Eric Espie
e930d34963
N°4305 - n-n links to same class - Fix aliases in request
2021-09-20 16:09:32 +02:00
bruno-ds
daf24d8cb3
N°4261 - implement feedbacks from the team
...
plus:
- the entrypoint is now `LogException()` instead of `FromException()` which sounded more like a factory and less like an active method.
- merge conflicting commit with @molkobain (CC fix)
- remove the writing of the exception object in the error.log context (adding it was an error, it's way too verbose!!).
- Technical note: The context is still used to propagate the exception across several call stack, so it now uses a less generic naming in order to avoid conflicts (see `ExceptionLog::CONTEXT_EXCEPTION`). another solution would have been to add a new parameter to `ExceptionLog::Log()`, but I didn't want to add constraint over the hypothetical evolution of the base class method.
2021-09-20 12:27:39 +02:00
bruno-ds
6e0d570d41
N°4261 - Portal exception logging: Add exception's file and line to the context.
...
plus:
- the exception object is no more automatically added to the error.log context (it's way too verbose)
- code cleanup (use constant instead of repeated strings)
- ExceptionLog main method is now named `LogException` instead of `FromException`
2021-09-20 12:27:39 +02:00
Molkobain
6271a33fdb
Code review: Fix code conventions
2021-09-16 14:53:40 +02:00
Pierre Goiffon
adc7666dd0
💚 Change setup.css test
...
Was checking comment presence, but we removed the comments (N°3865)
2021-09-16 10:21:21 +02:00
Molkobain
c025a7aa3b
N°3685 - Add unit test for WebResourcesHelper
2021-09-15 16:16:20 +02:00
bruno-ds
d1721b0834
N°4261 -Fix CI
...
Try to repair an odd error in the CI:
> Fatal error: Uncaught Exception: Serialization of 'ReflectionClass' is not allowed
avoid instantiation in the provider, delay them to the actual test
2021-09-15 14:39:00 +02:00
bruno-ds
66e4f369f7
N°4261 -Fix CI
...
Try to repair an odd error in the CI:
> Fatal error: Uncaught Exception: Serialization of 'ReflectionClass' is not allowed
Maybe it's triggered by the mocks being a property of the test class, so I inlined them.
+ misc. minor modification in order to try to figure out what is causing this behavior.
2021-09-15 13:34:04 +02:00
bruno-ds
5d23a250ae
N°4261 - New log handler dedicated to Exceptions & use of it in the portal's Exception listener
...
Such Exceptions are triggered with a Warning level and default the minimum default level in order to write in DB is above, so the behavior is not modified:
- logs are written in errors.log (with a warning elvel instead of an error)
- logs are not written in DB unless `log_level_min.write_in_db` is changed
2021-09-14 17:40:11 +02:00
Eric Espie
4433cdb21b
N°4047 - Fix undefined offset in core\dbobject.class.php - rewrite duplicate check
2021-09-14 16:13:43 +02:00
Eric Espie
eef3e9b7ae
Merge branch 'develop' into SessionManagement
2021-09-07 16:33:10 +02:00
odain
3c081461b0
fix ci: use env-production instead
2021-09-07 15:22:46 +02:00
Molkobain
cf556de76e
Add method to get number of entries of an ormCaseLog
2021-08-27 17:28:01 +02:00
Eric
2c2155a8e0
N°3985 - Performance checks on the back end
2021-08-23 13:57:03 +02:00
Molkobain
5651512f68
N°4244 - Add protection against unfortunate massive delete of inline images / attachments when a null temp ID is passed
2021-08-17 15:58:52 +02:00
Molkobain
7577fbb8bf
N°4236 - Fix user with no admin right can't connect in iTop when log_usage set to true
2021-08-12 11:13:59 +02:00
Pierre Goiffon
cd1ba097cb
N°3867 Fix error "LEVEL_WARNING of type Identifier is forbidden" error when saving valid config in configuration editor
2021-08-11 18:07:38 +02:00
Pierre Goiffon
2d98ca2318
N°3867 Fix "Invalid configuration: Stmt_Expression is forbidden in line 10" error when saving valid config in configuration editor
...
Now this is tested in \ConfigValidator\iTopConfigAstValidatorTest
2021-08-11 16:38:56 +02:00
odain
92add2bbfe
add annotation to datasynchro test
2021-08-11 10:17:35 +02:00
Pierre Goiffon
cbdc48b7e1
✅ iTopConfigParserTest now works on Windows
2021-08-10 11:48:13 +02:00
denis.flaven@combodo.com
bb5679959e
Fixed unit tests for password_renewed_date, broken by the correction of
...
n°4095.
2021-08-10 10:40:54 +02:00
Pierre Goiffon
b8a0d899f4
✅ Fix \coreExtensions\UserLocalTest::testValidatePassword failing because of DEPRECATED notices
2021-08-06 17:13:24 +02:00
Pierre Goiffon
56a4fb0b42
Allow to run all tests from within the IDE
...
Just :
* configure the config file (test\phpunit.xml.dist)
* add runner parameters : --fail-on-risky --exclude-group beforeSetup
* specify iTop root as custom working directory
2021-08-05 15:21:41 +02:00
Molkobain
431dc5532b
Change comment / test for clarification
2021-07-28 15:59:43 +02:00
Eric
f4345ef312
N°4199 - Add <code> to EnumSet values to fix XML conversion
2021-07-28 14:40:19 +02:00
Eric
13b548e95d
N°4199 - Add <code> to EnumSet values to fix XML conversion
2021-07-28 14:39:52 +02:00
Eric
3a988ab499
N°4175 - Adding a lifecycle to an existing class fails on setup (using xml version < 3.0)
2021-07-28 13:30:39 +02:00
Eric
8dae459b12
N°4036 - User edition controls : the profiles selection should allow the User modification (when editing your own User)
2021-07-28 11:45:02 +02:00
Eric
8dc10424e8
🎨 cleanup code
2021-07-28 09:59:10 +02:00
Eric
1d5e0b6fe9
Temporary ignored test for CI
2021-07-27 18:01:39 +02:00
Pierre Goiffon
bd67b71f3d
Merge remote-tracking branch 'origin/support/2.7' into develop
2021-07-06 11:36:34 +02:00
Molkobain
7ca689e190
Setup: Fix sizes being displayed as bits instead of bytes
2021-07-04 22:49:54 +02:00
Pierre Goiffon
e32e275f40
🎨 Align dataprovider elements
2021-06-29 16:45:34 +02:00
Pierre Goiffon
aa9ab1ace5
Merge remote-tracking branch 'origin/support/2.7' into develop
...
# Conflicts:
# css/css-variables.scss
# datamodels/2.x/authent-cas/module.authent-cas.php
# datamodels/2.x/authent-external/module.authent-external.php
# datamodels/2.x/authent-ldap/module.authent-ldap.php
# datamodels/2.x/authent-local/module.authent-local.php
# datamodels/2.x/combodo-db-tools/module.combodo-db-tools.php
# datamodels/2.x/itop-attachments/module.itop-attachments.php
# datamodels/2.x/itop-backup/module.itop-backup.php
# datamodels/2.x/itop-bridge-virtualization-storage/module.itop-bridge-virtualization-storage.php
# datamodels/2.x/itop-change-mgmt-itil/module.itop-change-mgmt-itil.php
# datamodels/2.x/itop-change-mgmt/module.itop-change-mgmt.php
# datamodels/2.x/itop-config-mgmt/module.itop-config-mgmt.php
# datamodels/2.x/itop-config/module.itop-config.php
# datamodels/2.x/itop-core-update/module.itop-core-update.php
# datamodels/2.x/itop-datacenter-mgmt/module.itop-datacenter-mgmt.php
# datamodels/2.x/itop-endusers-devices/module.itop-endusers-devices.php
# datamodels/2.x/itop-files-information/module.itop-files-information.php
# datamodels/2.x/itop-full-itil/module.itop-full-itil.php
# datamodels/2.x/itop-hub-connector/module.itop-hub-connector.php
# datamodels/2.x/itop-incident-mgmt-itil/module.itop-incident-mgmt-itil.php
# datamodels/2.x/itop-knownerror-mgmt/module.itop-knownerror-mgmt.php
# datamodels/2.x/itop-portal-base/module.itop-portal-base.php
# datamodels/2.x/itop-portal/module.itop-portal.php
# datamodels/2.x/itop-problem-mgmt/module.itop-problem-mgmt.php
# datamodels/2.x/itop-profiles-itil/module.itop-profiles-itil.php
# datamodels/2.x/itop-request-mgmt-itil/module.itop-request-mgmt-itil.php
# datamodels/2.x/itop-request-mgmt/module.itop-request-mgmt.php
# datamodels/2.x/itop-service-mgmt-provider/module.itop-service-mgmt-provider.php
# datamodels/2.x/itop-service-mgmt/module.itop-service-mgmt.php
# datamodels/2.x/itop-sla-computation/module.itop-sla-computation.php
# datamodels/2.x/itop-storage-mgmt/module.itop-storage-mgmt.php
# datamodels/2.x/itop-tickets/module.itop-tickets.php
# datamodels/2.x/itop-virtualization-mgmt/module.itop-virtualization-mgmt.php
# datamodels/2.x/itop-welcome-itil/module.itop-welcome-itil.php
# datamodels/2.x/version.xml
2021-06-29 16:12:49 +02:00
Eric
0396914068
N°3513 - Write object creation history within the same DB transaction for better consistency
2021-06-28 16:59:05 +02:00
Eric
c0fbf0c735
✅ Fix DBObject::EvaluateExpression() tests
2021-06-28 16:21:46 +02:00
Pierre Goiffon
b5074c4cee
N°3806 Fix saying memory_limit isn't enough in CLI scripts and setup
...
This was caused by the strict comparison in \utils::IsMemoryLimitOk for the special "-1" value of memory_limit, which was added in c2f5cafa
2021-06-28 14:53:39 +02:00
Pierre Goiffon
2a1e0b7429
Merge remote-tracking branch 'origin/support/2.7' into develop
...
# Conflicts:
# core/dbobject.class.php
# core/log.class.inc.php
# setup/compiler.class.inc.php
2021-06-28 08:58:34 +02:00
Eric
949b213f9d
N°3513 - revert crud sequence
2021-06-24 13:32:43 +02:00
Eric
b1ca1f2630
N°3513 - ObjectFormManager : remove transaction
...
* Add automatic tests
* Fix object consistency
2021-06-22 16:09:41 +02:00
odain
4d123e1450
fix ci
2021-06-22 10:00:18 +02:00
acognet
224031e0d6
N°3905 - Polishing: CSV Import
2021-06-18 17:00:39 +02:00
odain
c413ac989e
fix ci: add anotations to be able to exclude tests
2021-06-16 18:25:10 +02:00
Pierre Goiffon
d8e2a1cc7c
Merge branch 'support/2.7' into develop
...
# Conflicts:
# README.md
# composer.json
# composer.lock
# core/cmdbsource.class.inc.php
# core/dbobject.class.php
# datamodels/2.x/combodo-db-tools/db_analyzer.class.inc.php
# datamodels/2.x/combodo-db-tools/dbtools.php
# datamodels/2.x/combodo-db-tools/dictionaries/zh_cn.dict.combodo-db-tools.php
# datamodels/2.x/itop-attachments/dictionaries/zh_cn.dict.itop-attachments.php
# datamodels/2.x/itop-core-update/dictionaries/zh_cn.dict.itop-core-update.php
# dictionaries/zh_cn.dictionary.itop.core.php
# dictionaries/zh_cn.dictionary.itop.ui.php
# lib/composer/InstalledVersions.php
# lib/composer/autoload_classmap.php
# lib/composer/autoload_static.php
# lib/composer/installed.php
# lib/composer/platform_check.php
# pages/ajax.render.php
# pages/csvimport.php
# setup/ajax.dataloader.php
# setup/index.php
# setup/setuputils.class.inc.php
# test/application/UtilsTest.php
2021-06-14 16:19:56 +02:00
Eric
d11eceac62
✅ N°4052 - OQL parser limit for huge request - fix CI
2021-06-03 17:07:17 +02:00
Eric
02d32a556d
N°4052 - OQL parser limit for huge request
2021-06-02 15:15:00 +02:00
Eric
71fcc6f026
N°4031 - OQL Error when AttributeObjectKey is used in JOIN condition
2021-06-02 14:45:03 +02:00
Pierre Goiffon
a395c1760a
N°4047 skip test generating a PHP notice
...
Will be fixed later
2021-06-01 16:51:44 +02:00
Pierre Goiffon
caa2a05bf4
🔧 restore .editorconfig
...
Was moved to /test by mistake
And also editorconfig syntax was removed :(
Those mistakes were done in 7f15eed9
2021-05-26 15:19:40 +02:00
Pierre Goiffon
44952d1ea0
✅ Fix \UtilsTest::testIsMemoryLimit
2021-05-25 17:04:32 +02:00
