Commit Graph

1111 Commits

Author SHA1 Message Date
Romain Quetiez
0b4597e65e (Retrofit from trunk) N.799 Setup failing (during database creation) with MetaEnum attribute having no mapping for the class they are declared in.
SVN:2.3[4637]
2017-03-30 19:26:02 +00:00
Romain Quetiez
60fa0e08f0 (Retrofit from trunk) N.609 Some multi-column UNION queries failing with various symptoms such as "Class 'IT Department' not found" or "An object id must be an integer value"
SVN:2.3[4635]
2017-03-29 20:00:00 +00:00
Romain Quetiez
c15853d982 (Retrofit from trunk) N.740 Error when attempting to disable the logs. Took the opportunity to refactor, relying on late static bindings (requires PHP 5.3). The refactoring avoided the fix to be duplicated in three places.
SVN:2.3[4629]
2017-03-29 08:29:57 +00:00
Romain Quetiez
c0fd0e736f (Retrofit from trunk) N.519 REST/JSON Add a comment in pure text into the case log (only for add_item/items syntaxes, use format="text")
SVN:2.3[4620]
2017-03-23 15:18:13 +00:00
Romain Quetiez
40fbdcc88c (Retrofit from trunk) N.692 Config setting log_queries does not work? This setting has been deprecated (use log_kpi_duration instead) - Still the implementation of query logging remains (and is buggy) as it may be usefull in order to record and rebuild a complete set of queries.
SVN:2.3[4616]
2017-03-23 09:11:09 +00:00
Romain Quetiez
76839b1b2c (Retrofit from trunk) N.718 Audit failing with message "Attempting to merge a filter of class A with a filter of class B" (regression introduced in branch 2.3). There are circumstances for which the queries cannot (yet) be optimized (fallback to the original algorithm) (note: this retrofit includes both commits made on trunk)
SVN:2.3[4613]
2017-03-22 21:01:44 +00:00
Romain Quetiez
2a60a57c46 Retrofit from trunk - N.701 Data Synchro: dates can be reset by the mean of an empty string (still, integers and enums cannot be reset)
SVN:2.3[4597]
2017-03-17 09:16:23 +00:00
Romain Quetiez
f42e641faf ReRetrofit from trunk - N.453 Emails coming from outlook. Many line breaks added when editing the ticket
SVN:2.3[4581]
2017-03-14 13:21:53 +00:00
Romain Quetiez
635ca103af Retrofit from trunk - N.757 Server log filled with warnings (ContextTag::Check)
SVN:2.3[4574]
2017-03-10 14:43:28 +00:00
Guillaume Lajarige
08cda15762 (Retrofit from trunk) N°602: InlineImage "randomly" not available for display.
Adding an InlineImage while adding an object in a IndirectLinkedSet at the same time would attach the InlineImage to the linked object instead of the host one. If their organizations were different, it could result in a security issue, denying the display of the InlineImage.

SVN:2.3[4562]
2017-02-28 09:51:23 +00:00
Denis Flaven
3c384ff498 Retrofit from trunk: Bug fix: protect against a non existing Contact class (a rather drastic iTop customization!)
SVN:2.3[4560]
2017-02-24 14:11:24 +00:00
Denis Flaven
f7f4fbce51 (retrofir from trunk) N° 615: spreadsheet export enhancement to remove unneeded line breaks.
SVN:2.3[4550]
2017-01-31 13:32:16 +00:00
Romain Quetiez
e7eecf81ee (Retrofit from trunk) N.497 Continuation of the fix done in [r4461], to correctly handle validation patterns containing a slash (AttributeURL in the enhanced customer portal). The initial fix has broken the validation of date (+time) fields because the slash was escaped twice, leading to an invalid regular expression. Requires testing of synchro, CSV import, console, customer portal...
SVN:2.3[4539]
2016-12-19 16:11:46 +00:00
Denis Flaven
f1966619b9 (Retrofit from trunk) Support of the "target" attribute for links.
SVN:2.3[4525]
2016-12-14 11:17:04 +00:00
Denis Flaven
01fa323b38 (Retrofit from trunk) Support of text-align in the styles.
SVN:2.3[4523]
2016-12-14 11:15:31 +00:00
Guillaume Lajarige
c0ba515797 (Retrofit from trunk) N.474: Support for "file" attribute (AttributeBlob) in the portal. READONLY only for now.
SVN:2.3[4513]
2016-12-13 10:18:00 +00:00
Guillaume Lajarige
60ae969c89 (Retrofit from trunk) N.481: Portal: Impossible to submit a form with a duration attribute. Also fixed the displayed value in tables (ManageBrick and BrowseBrick)
SVN:2.3[4505]
2016-12-08 11:38:09 +00:00
Romain Quetiez
bc0645d5cc (Retrofit from trunk) N.490 Losing carrier returns and rich text formatting when the latest comments are copied to child tickets
SVN:2.3[4503]
2016-12-08 10:27:00 +00:00
Romain Quetiez
d651196eae (Retrofit from trunk) N.539 Regression introduced in [r4451] on oct 7th. Some OQL were issuing a notice and some were generating a SQL query that would fail with error "Column 'functionalci_id' in where clause is ambiguous" (See CI details)
SVN:2.3[4493]
2016-12-05 12:54:32 +00:00
Romain Quetiez
73bedb1522 (Retrofit from trunk) Continuing [r4488] N.536 Regression introduced in [r4469] (N.505), itself fixing a regression introduced in [r4404]. REQUIRES TESTING
SVN:2.3[4491]
2016-12-05 10:00:27 +00:00
Romain Quetiez
b2f42ae3f4 (Retrofit from trunk) N.536 Regression introduced in [r4469] (N.505), itself fixing a regression introduced in [r4404]. REQUIRES TESTING
SVN:2.3[4489]
2016-12-02 20:43:17 +00:00
Romain Quetiez
3277be00c1 (Retrofit from trunk) N.527 Enable the template placeholders for AttributeCustomFields
SVN:2.3[4482]
2016-11-25 16:39:30 +00:00
Romain Quetiez
89b4de01a9 (Retrofit from trunk) N.523 UserRights::ListProfiles must return an empty array if nobody is currently logged in (instead of a FATAL ERROR)
SVN:2.3[4479]
2016-11-18 15:49:03 +00:00
Denis Flaven
5d16ab9654 (retrofit from trunk): APCu comptability layer. Retrofit after validation.
SVN:2.3[4476]
2016-11-15 10:47:24 +00:00
Romain Quetiez
e0f3cdac51 (Retroffit from trunk) N.505 Regression introduced in [r4404]. Security issue - Object visibility totally screwed the APC cache (user data) is enabled. This is a change in the way SQL queries are built and therefore requires testing.
SVN:2.3[4470]
2016-10-28 09:10:22 +00:00
Romain Quetiez
4a6e08e3e9 N.504 Could not jump into the designer (APC, random)
SVN:2.3[4468]
2016-10-27 15:00:14 +00:00
Romain Quetiez
3992425a27 (Retrofit from trunk) N.466 HTML links with href="ftp://..." or "file://...". The filtering implemented by default (DOM Sanitization) now takes the configuration parameter url_validation_pattern into account. Thus aligning the behavior between HTML attributes and AttributeURL, and the automatic wiki formatting. By default, iTop allows the protocols http/https/ftp. To allow the 'file' protocol, edit the config file and change url_validation_pattern accordingly.
SVN:2.3[4456]
2016-10-10 16:03:32 +00:00
Romain Quetiez
5807ae79d2 (Retrofit from trunk) N.434 Optimized the DB queries. As an example, the query that shows the service catalog in the enhanced customer portal is now made of 5 nodes (at the class level) whereas it used to be made of 11 nodes... for the exact same results. This optimization impacts almost each queries built by iTop. The expected benefit can insignificant or not, depending on the cardinality of the data, the datamodel and the original OQL queries. We found one case where the query execution would apparently never end and it takes now less than a second. The OQL parsing is impacted too. This retrofit include [r4448] and [r4451].
SVN:2.3[4452]
2016-10-10 09:03:45 +00:00
Guillaume Lajarige
e1c51d278e (Retrofit from trunk on bahalf of rquetiez) N°436 Core API: Correctly (mathematically!) handle the "allow all data" flag, with UNIONS and INTERSECTIONS. Requires testing
SVN:2.3[4445]
2016-10-06 07:12:02 +00:00
Guillaume Lajarige
85b38a07ee (Retrofit from trunk on bahalf of rquetiez) #1323 error.log polluted with the contents of each email sent (transport = PHPMail)
SVN:2.3[4444]
2016-10-06 07:10:51 +00:00
Romain Quetiez
d7ee97f5a4 (Retrofit from trunk) Prerequisite for #1334. New API: DBObjectSet::SetOrderByClasses. Helper to sort on multicolumn queries (SELECT a, b FROM)
SVN:2.3[4414]
2016-09-23 15:31:18 +00:00
Romain Quetiez
bfcc6ea239 (Retrofit from trunk) #1178 Internals: Object Update/Reload should never fail: as soon as a given object has been read in the current execution context, updating/reloading it is not an issue.
SVN:2.3[4403]
2016-09-15 10:03:41 +00:00
Romain Quetiez
a574b1b4e8 (Retrofit from trunk) #1325 Could not declare an ext key to a subclass (view could not be created). This commit is minimalistic and aims at being retrofitted into the various branches of iTop. It will be followed by a second commit, which aims at completing the fix by aligning the internal data structures of iTop... and possibly fix an issue (?)
SVN:2.3[4400]
2016-09-14 15:54:33 +00:00
Romain Quetiez
49a1052333 (Retrofit from trunk) Fixes a regression introduced in [r4385] and causing a blank screen when editing an object
SVN:2.3[4391]
2016-09-06 13:51:15 +00:00
Romain Quetiez
a222f296ef (Retrofit from trunk) Rich text editor: the Maximize button icon is missing if iTop is installed in a directory which name contains spaces
SVN:2.3[4385]
2016-09-06 09:36:57 +00:00
Guillaume Lajarige
096236cb3a (Retrofit from trunk) Portal : External keys OQL now intersect with scopes in forms!
SVN:2.3[4381]
2016-09-06 07:06:13 +00:00
Romain Quetiez
600c447529 #1321 Losing table borders (and other options configurable in the rich text editor)
SVN:2.3[4377]
2016-09-05 13:06:51 +00:00
Guillaume Lajarige
4f1be53b68 (Retrofit from trunk on behalf of rquetiez) Improved the comments for access_mode in the config file
SVN:2.3[4375]
2016-09-02 14:14:56 +00:00
Romain Quetiez
dfdec57d3f (Retrofit from trunk) CSV import failing with final class (localized value not taken into account)
SVN:2.3[4349]
2016-08-24 16:58:32 +00:00
Denis Flaven
43dd075c44 (retrofit from trunk) Regression introduced after 2.3.0-beta [r4217]: broken links to download / display blobs.
SVN:2.3[4320]
2016-08-10 15:55:31 +00:00
Denis Flaven
1632c51abd (retrofit from trunk) Performance optimization: do not load all the columns when it is not needed.
SVN:2.3[4318]
2016-08-10 14:58:59 +00:00
Denis Flaven
45c0ad5597 (retrofit from trunk) Image upload inside CKEditor (via drag and drop) seems to be desactivated on IE9.
SVN:2.3[4316]
2016-08-05 10:19:30 +00:00
Denis Flaven
e553c0bbe1 Prevent timeouts during the (lengthy) PDF conversion...
SVN:trunk[4293]
2016-07-06 09:43:20 +00:00
Denis Flaven
18f15ba9cc Fixed the case for the Emogrifier includes.
SVN:trunk[4292]
2016-07-06 09:22:43 +00:00
Denis Flaven
775ed7d437 Regresssion of iTop 2.3.0 beta: properly load the metamodel from the environment.
SVN:trunk[4287]
2016-07-05 13:37:40 +00:00
Romain Quetiez
dee3d55af2 Code cleanup: removed unused parameter (not used, thus confusing)
SVN:trunk[4286]
2016-07-05 12:08:00 +00:00
Denis Flaven
0d48e40c18 Regresssion: properly compute & record the history of StopWatch's sub-items.
SVN:trunk[4285]
2016-07-05 12:07:20 +00:00
Denis Flaven
a0965c2a52 Use the configurable date & time format for displaying the history of StopWatches.
SVN:trunk[4284]
2016-07-05 11:57:16 +00:00
Romain Quetiez
07db5855a2 Fixed regression in 2.3.0-beta: placeholder $public_log$ was generating a mix of plain text and HTML markup whereas only plain text is expected
SVN:trunk[4280]
2016-07-05 09:50:10 +00:00
Romain Quetiez
396c4564b4 HTML formatting: TWO fixes in one! Fixed a bug introduced in 2.3.0-beta: the stylesheet cannot be defined within the email templates (aka ActionEmail) anymore. Instead, a default (ready for use) stylesheet is provided into /css/email.css and it can be overriden by the configuration parameter email_css. The fix consists in transforming the stylesheet into inline style... which fixes a limitation of gmail and Outlook that support only the inline styles. The implementation relies on a new library: emogrifier. This library has been changed (home-made utility) to be compatible with PHP 5.3 (declaration of arrays).
SVN:trunk[4277]
2016-07-04 15:06:28 +00:00