Pierre Goiffon
0e14be8b15
N°4261 Refactor ExceptionLog ( #239 )
...
Doing a code review with Bruno, we agreed to do some little refactoring :
* Level per exception class
- Before the whole ExceptionLog::Log method was a total rewrite of its parent, with some code duplicates... not a good idea : we should better improve LogAPI to make other similar uses possible in the future !
- The logic to get level from config must be in a GetMinLogLevel override
* Write to DB
- Pull up this functionnality in LogAPI
- Add a sCode parameter in GetLevelDefault
Doing this refactoring, I also improved :
* Test the attributes set when creating the EventIssue object : during my dev I had crashes because I didn't filled all the mandatory fields... Having a PHPUnit test checking this will prevent future bugs to happen if attributes are modified in the class or in the object creation method
* Use Throwable instead of Exception : this was added in PHP 7.0 and will allow to catch both Exception and Error
* Because we need to have 2 statements on the same line in \Combodo\iTop\Test\UnitTest\Core\Log\ExceptionLogTest::testLogInFile, I modified the editorConfig file to allow disabling the formatter using comments.
2021-10-20 16:01:08 +02:00
Pierre Goiffon
ef6d7925fc
Log : always log the same structure, and add a delimiter at the end
...
This will allow to parse the logs more easily !
2021-10-20 15:16:57 +02:00
Eric Espie
e0929f4d0d
N°4375 - Change CKEditor plugins init
2021-10-19 17:16:17 +02:00
Molkobain
e53a45ec5d
N°2875 - Update config. param.
2021-10-19 15:40:42 +02:00
Molkobain
cdf5789d62
N°2875 - Add $bRootFirst param. to MetaModel::EnumChildClasses() to be iso with MetaModel::EnumParentClasses()
2021-10-19 15:16:43 +02:00
Molkobain
8f2b5ad8e2
N°2875 - Invert TriggerOnObjectMention approach
...
- Trigger is now positioned on a specific "host" class (eg. Ticket)
- Trigger now has a "mentioned objects" filter which determines the scope of mentioned objects which will activate the trigger
2021-10-19 15:16:42 +02:00
Molkobain
df49e9c3b5
N°2875 - Add class icon to Trigger and Action
2021-10-19 15:16:42 +02:00
Eric Espie
8a7f0d346d
N°4375 - Change CKEditor plugins init
2021-10-19 11:04:33 +02:00
Molkobain
be24d409ed
Config: Move security.hide_administrators parameter with other security.xxx parameters
2021-10-12 18:01:56 +02:00
acognet
7f0493c91d
N°3928 - Polishing: Impact analysis
2021-10-07 18:11:04 +02:00
denis.flaven@combodo.com
bf4835eec0
N°4354 - Hide Administrator profile to non-admins
2021-10-06 15:34:23 +02:00
acognet
0cb1583688
N°1731 - Allow Transitions without unnecessary confirmation - add force_transition_confirmation param
2021-10-05 11:36:08 +02:00
Molkobain
8af54efd44
N°4068 - Object details: Avoid image attributes to overlap other attributes when they are very large
...
- Keep its width contained in the column
- Maintain aspect ratio of the container div to hint the user on which size the image should be
- Keep image real size as long as it fits in the container
2021-10-02 10:25:19 +02:00
Molkobain
9ea25188ba
N°3925 - Fix state flags not taken into account correctly by a child class (regression from f2ff5a4e)
2021-09-30 19:41:56 +02:00
Eric Espie
4b8ef4f919
N°3572 - Fix Data Integrity tab results display
...
- fix synchrodatasource SQL definitions
- fix Hierarchical keys warnings due to bad parameters
2021-09-30 14:53:00 +02:00
Pierre Goiffon
c3d23981fb
💡 Document limitation in \LogAPI::GetConfig
2021-09-30 14:45:06 +02:00
Pierre Goiffon
9c6d8253f4
✅ Fix \Combodo\iTop\Test\UnitTest\Core\CMDBSourceTest::testIsOpenedDbConnectionUsingTls
2021-09-30 10:49:11 +02:00
Pierre Goiffon
8fa6ae6703
Merge remote-tracking branch 'origin/support/2.7' into develop
...
# Conflicts:
# core/cmdbsource.class.inc.php
2021-09-30 09:51:13 +02:00
Pierre Goiffon
fdc987f367
Merge remote-tracking branch 'origin/support/2.7.5' into support/2.7
2021-09-29 17:51:17 +02:00
Stephen Abello
aac504ec0b
N°3917 Fix object details icon cover method when using class highlight icon as object icon
2021-09-28 16:25:47 +02:00
denis.flaven@combodo.com
a7a7ce77fb
N°4096 - Automatic email sending retry in case of error.
2021-09-28 15:42:28 +02:00
Stephen Abello
5680d9579c
N°3917 Refactor algorithm to get object details semantic image icon in object's GetIcon method in order to propagate this feature anywhere where GetIcon is called
2021-09-28 15:01:06 +02:00
Molkobain
ec47645ef7
Merge branch 'support/3.0.0-beta5' into develop
2021-09-28 12:58:08 +02:00
Molkobain
4c6a7ca30b
N°3791 - Fix crash when displaying object with a null state value
2021-09-28 12:51:21 +02:00
Eric Espie
f67f3eaf74
N°4326 - Fix unknown attribute when no state attcode is given
2021-09-27 14:43:12 +02:00
acognet
580deb655d
Remove unused tablesorter
2021-09-27 09:25:20 +02:00
Molkobain
3214ae91c7
N°3791 - Panel: Use style defined in the DM for classes
...
Note that for now, semantic colors cannot be used directly in a <main_color> or <complementary_color> tag. Only valid CSS color (hexa, hsla, ...)
2021-09-26 15:15:34 +02:00
Molkobain
21545da062
Rename Panel / Alert / Button color constants for something more accurate
...
Done now before their as used too widely. We are most likely to allow dev. to use custom colors soon, so we want to avoid confusing / renaming then. (iTop extensions have been verified, none had to be migrated)
2021-09-26 01:26:42 +02:00
Molkobain
ca7f6362bf
ormStyle: Fix icon URL including the app. root in the MetaModel to ease usage with load balancers
2021-09-25 17:00:50 +02:00
Pierre Goiffon
3ff117596d
💡 N°4325 add phpdoc
2021-09-24 17:16:59 +02:00
Pierre Goiffon
4cf4c0e4c3
♻️ N°4325 refactor CMDBSource mysqli attributes to a separate wrapper class ( #237 )
...
In 2.7.5 with N°3513 we added a second mysqli attribute in CMDBSource, so that we can test transactions (see TransactionsTest).
But this wasn't documented, and was really causing confusion !
This refactor wraps both attributes in a dedicated object so that the logic is clearer.
2021-09-24 11:45:39 +02:00
Molkobain
e93c0123aa
PHPDoc
2021-09-23 18:12:52 +02:00
Pierre Goiffon
ec1dcc8df6
💡 N°3513 PHPDoc
2021-09-23 14:42:16 +02:00
Pierre Goiffon
47ed863da9
N°4215 N°3513 Fix DB errors fetch from the wrong object n°2
2021-09-23 14:32:43 +02:00
Pierre Goiffon
88290f9e91
N°4215 N°3513 Fix DB errors fetch from the wrong object
2021-09-23 13:55:23 +02:00
Molkobain
3a05e9159d
PHPDoc
2021-09-23 12:29:34 +02:00
Pierre Goiffon
cfdbc8ae62
N°4215 When checking for TLS cnx, don't set anymore CMDBSource mysql attributes !
2021-09-23 11:59:44 +02:00
Molkobain
e2b73995e1
N°3882 - Move DataModel classes fields' style to theme instead of (duplicated) inline CSS
2021-09-23 11:44:11 +02:00
Molkobain
24cedbdebd
PHPDoc
2021-09-23 11:44:11 +02:00
acognet
03a19ab3f4
N°2573 - Remove MetaModel::GetNextKey
2021-09-23 11:36:10 +02:00
Stephen Abello
70d7f576f3
N°4001 Remove empty lines from tag set tooltips
2021-09-23 10:31:06 +02:00
acognet
40ec7e35fd
N°4245 - Using customfield in notifications triggered by TriggerOnObjectUpdate via ApplyStimulus
2021-09-23 09:20:33 +02:00
acognet
e97a266c44
N°3946 - LogAPI : log config parameters aren't used when logging in the setup wizard context
2021-09-23 09:19:54 +02:00
Eric Espie
b4278a6987
Supportability: Add UserId in EventIssue if 'userinfo' field is empty
2021-09-23 08:25:32 +02:00
Pierre Goiffon
aaa8f6d311
N°4215 Fix call to a function on null error when setting TLS connection in the setup
...
Regression introduced by b1ca1f2630
2021-09-22 15:59:39 +02:00
Molkobain
fd933ce49a
N°4245 - Temporary partial rollback
2021-09-22 13:34:13 +02:00
Stephen Abello
7c7386afc7
N°3851 Update Emogrifier to a version supporting iTop PHP versions range
2021-09-21 16:45:12 +02:00
bruno-ds
c306c6e30d
N°4261 - code review with @PirGoif
2021-09-21 16:38:10 +02:00
Eric Espie
d8316734e2
N°4305 - n-n links to same class - Be more robust on original search given to ormLinkSet
2021-09-21 15:46:20 +02:00
Pierre Goiffon
f0aaf21a79
💚 N°3002 Fix php-mock-objects notices
...
The error handler now checks if logger is enabled before doing anything
2021-09-21 12:01:42 +02:00
