Commit Graph

6 Commits

Author SHA1 Message Date
Molkobain
825c70c001 Introduce type hinting in methods prototype (PHP >= 7.1) 2020-08-26 21:22:39 +02:00
Molkobain
77cd764b1c PHPDoc & code cleanup 2020-08-26 21:22:25 +02:00
Molkobain
b5c97e35bf Add visibility to class constants (PHP >= 7.1) 2020-08-26 19:02:53 +02:00
Molkobain
d2bf4de84c N°2847 - Refactor some early choices
- TWIG: Change calls to object methods from simple notation (eg. oObject.Id) to complete notation (eg. oObject.GetId()) to avoid confusion with use of arrays and variables (eg. aObject.sId)
- UIBlock: $sId should not be first parameter as most of the time it can be ignored and generated by the system
- NewsroomMenu: Rename method for something more less ambiguous
- Html: Embed content in <div /> so we can easily find all such HTML fragments in the UI
2020-08-26 16:03:33 +02:00
Stephen Abello
f8b6b37288 N°2847 Recolor svg illustrations with itop's primary color 2020-08-10 16:56:00 +02:00
Stephen Abello
a5216de232 N°2847 First iteration for newsroom menu:
* Kept old js widget but refactored/tweak'd it with some of our new conventions
* Added a newsroom menu component extending popupmenu
* Working as in 2.7
Still todo :
* Add variables for scss file
* Use wiget variables for most of js widget
* Correctly place the popup (absolute with <> containers ? poppers.js ? )
* Intialize toggler red bubble when new messages are in
* Replace hardcoded text in usermenu with correct dict entry updated with the nb of new message
* Only allow to open the popup when ajax calls are done
2020-08-06 14:36:07 +02:00