composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-09-10 15:48:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°4898 - security hardening

Browse Source
This commit is contained in:
acognet
2022-05-30 15:06:16 +02:00
parent ddb95dc64e
commit fe1790793e
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/dbobject.class.php
View File

@@ -1880,7 +1880,7 @@ abstract class DBObject implements iDisplay
$oTargetObj = MetaModel::GetObject($sTargetClass, $toCheck, false /*must be found*/, true /*allow all data*/); $oTargetObj = MetaModel::GetObject($sTargetClass, $toCheck, false /*must be found*/, true /*allow all data*/);
if (is_null($oTargetObj)) if (is_null($oTargetObj))
{ {
return "Target object not found ($sTargetClass::$toCheck)"; return "Target object not found (".utils::HtmlEntities($sTargetClass).".::".utils::HtmlEntities($toCheck).")";
} }
} }
if ($oAtt->IsHierarchicalKey()) if ($oAtt->IsHierarchicalKey())
@@ -1889,7 +1889,7 @@ abstract class DBObject implements iDisplay
$aValues = $oAtt->GetAllowedValues(array('this' => $this)); $aValues = $oAtt->GetAllowedValues(array('this' => $this));
if (!array_key_exists($toCheck, $aValues)) if (!array_key_exists($toCheck, $aValues))
{ {
return "Value not allowed [$toCheck]"; return "Value not allowed [". utils::HtmlEntities($toCheck)."]";
} }
} }
} }
@@ -1903,7 +1903,7 @@ abstract class DBObject implements iDisplay
$oTag->SetValues(explode(' ', $toCheck)); $oTag->SetValues(explode(' ', $toCheck));
} catch (Exception $e) } catch (Exception $e)
{ {
return "Tag value '$toCheck' is not a valid tag list"; return "Tag value [". utils::HtmlEntities($toCheck)."] is not a valid tag list";
} }
return true; return true;
@@ -1931,7 +1931,7 @@ abstract class DBObject implements iDisplay
$oTag->SetValues($aValues); $oTag->SetValues($aValues);
} catch (Exception $e) } catch (Exception $e)
{ {
return "Set value '$toCheck' is not a valid set"; return "Set value[". utils::HtmlEntities($toCheck)."] is not a valid set";
} }
return true; return true;
@@ -1951,7 +1951,7 @@ abstract class DBObject implements iDisplay
{ {
if (!array_key_exists($toCheck, $aValues)) if (!array_key_exists($toCheck, $aValues))
{ {
return "Value not allowed [$toCheck]"; return "Value not allowed [". utils::HtmlEntities($toCheck)."]";
} }
} }
if (!is_null($iMaxSize = $oAtt->GetMaxSize())) if (!is_null($iMaxSize = $oAtt->GetMaxSize()))
@@ -1964,7 +1964,7 @@ abstract class DBObject implements iDisplay
} }
if (!$oAtt->CheckFormat($toCheck)) if (!$oAtt->CheckFormat($toCheck))
{ {
return "Wrong format [$toCheck]"; return "Wrong format [". utils::HtmlEntities($toCheck)."]";
} }
} }
else else