From f9511aba17a87793bd180037b4d24b53695215db Mon Sep 17 00:00:00 2001
From: Pierre Goiffon <pierre.goiffon@combodo.com>
Date: Mon, 5 Mar 2018 15:50:38 +0000
Subject: [PATCH] =?UTF-8?q?N=C2=B01030=20Collapsible=20Sections=20:=20*=20?=
 =?UTF-8?q?stop=20event=20propagation=20(was=20causing=20tab=20switching?=
 =?UTF-8?q?=20in=20notifications)=20*=20save=20section=20state=20in=20loca?=
 =?UTF-8?q?lStorage?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

SVN:trunk[5382]
---
 application/itopwebpage.class.inc.php | 70 ++++++++++++++++++++++-----
 core/config.class.inc.php             | 12 +++++
 pages/notifications.php               |  2 +-
 pages/run_query.php                   |  2 +-
 4 files changed, 71 insertions(+), 15 deletions(-)

diff --git a/application/itopwebpage.class.inc.php b/application/itopwebpage.class.inc.php
index 1d1cd04bd..666236257 100644
--- a/application/itopwebpage.class.inc.php
+++ b/application/itopwebpage.class.inc.php
@@ -45,6 +45,8 @@ class iTopWebPage extends NiceWebPage implements iTabbedPage
 	protected $sBreadCrumbEntryIcon;
 	protected $oCtx;
 
+	protected $bHasCollapsibleSection = false;
+
 	public function __construct($sTitle, $bPrintable = false)
 	{
 		parent::__construct($sTitle, $bPrintable);
@@ -623,6 +625,7 @@ EOF
 		);
 	}
 
+
 	/**
 	 * @param string $sId Identifies the item, to search after it in the current breadcrumb
 	 * @param string $sLabel Label of the breadcrumb item
@@ -796,7 +799,7 @@ EOF
 		if ($iBreadCrumbMaxCount > 1)
 		{
 			$oConfig = MetaModel::GetConfig();
-			$siTopInstanceId = json_encode(utils::GetAbsoluteUrlAppRoot().'==='.$oConfig->Get('db_host').'/'.$oConfig->Get('db_name').'/'.$oConfig->Get('db_subname'));
+			$siTopInstanceId = json_encode($oConfig->GetItopInstanceid());
 			if ($this->bBreadCrumbEnabled)
 			{
 				if (is_null($this->sBreadCrumbEntryId))
@@ -821,6 +824,8 @@ EOF
 			);
 		}
 
+		$this->outputCollapsibleSectionInit();
+
 		if ($this->GetOutputFormat() == 'html')
 		{
 			foreach($this->a_headers as $s_header)
@@ -927,7 +932,7 @@ EOF
 				$sHtml .= "</script>\n";
 			}
 		}
-	
+
 		if (count($this->a_styles)>0)
 		{
 			$sHtml .= "<style>\n";
@@ -1241,6 +1246,38 @@ EOF;
 		ExecutionKPI::ReportStats();
 	}
 
+	/**
+	 * Adds init scripts for the collapsible sections
+	 */
+	private function outputCollapsibleSectionInit()
+	{
+		if (!$this->bHasCollapsibleSection)
+		{
+			return;
+		}
+
+		$this->add_script(<<<'EOD'
+function initCollapsibleSection(iSectionId, bOpenedByDefault, sSectionStateStorageKey)
+{
+var bStoredSectionState = JSON.parse(localStorage.getItem(sSectionStateStorageKey));
+var bIsSectionOpenedInitially = (bStoredSectionState == null) ? bOpenedByDefault : bStoredSectionState;
+
+if (bIsSectionOpenedInitially) {
+	$("#LnkCollapse_"+iSectionId).toggleClass("open");
+	$("#Collapse_"+iSectionId).toggle();
+}
+
+$("#LnkCollapse_"+iSectionId).click(function(e) {
+	localStorage.setItem(sSectionStateStorageKey, !($("#Collapse_"+iSectionId).is(":visible")));
+	$("#LnkCollapse_"+iSectionId).toggleClass("open");
+	$("#Collapse_"+iSectionId).slideToggle("normal");
+	e.preventDefault(); // we don't want to do anything more (see #1030 : a non wanted tab switching was triggered)
+});
+}
+EOD
+		);
+	}
+
 	public function AddTabContainer($sTabContainer, $sPrefix = '')
 	{
 		$this->add($this->m_oTabs->AddTabContainer($sTabContainer, $sPrefix));
@@ -1308,21 +1345,28 @@ EOF;
 		$this->add_ready_script($this->m_oTabs->SelectTab($sTabContainer, $sTabLabel));
 	}
 
-	public function StartCollapsibleSection($sSectionLabel, $bOpen = false)
-	{
-		$this->add($this->GetStartCollapsibleSection($sSectionLabel, $bOpen));
+	public function StartCollapsibleSection(
+		$sSectionLabel, $bOpenedByDefault = false, $sSectionStateStorageBusinessKey = ''
+	) {
+		$this->add($this->GetStartCollapsibleSection($sSectionLabel, $bOpenedByDefault,
+			$sSectionStateStorageBusinessKey));
 	}
 
-	public function GetStartCollapsibleSection($sSectionLabel, $bOpen = false)
-	{
+	private function GetStartCollapsibleSection(
+		$sSectionLabel, $bOpenedByDefault = false, $sSectionStateStorageBusinessKey = ''
+	) {
+		$this->bHasCollapsibleSection = true;
 		$sHtml = '';
 		static $iSectionId = 0;
-		$sImgStyle = $bOpen ? ' open' : '';
-		$sHtml .= "<a id=\"LnkCollapse_$iSectionId\" class=\"CollapsibleLabel{$sImgStyle}\" href=\"#\">$sSectionLabel</a></br>\n";
-		$sStyle = $bOpen ? '' : 'style="display:none" ';
-		$sHtml .= "<div id=\"Collapse_$iSectionId\" $sStyle>";
-		$this->add_ready_script("\$(\"#LnkCollapse_$iSectionId\").click(function() {\$(\"#Collapse_$iSectionId\").slideToggle('normal'); $(\"#LnkCollapse_$iSectionId\").toggleClass('open');});");
-		//$this->add_ready_script("$('#LnkCollapse_$iSectionId').hide();");
+		$sHtml .= '<a id="LnkCollapse_'.$iSectionId.'" class="CollapsibleLabel" href="#">'.$sSectionLabel.'</a></br>'."\n";
+		$sHtml .= '<div id="Collapse_'.$iSectionId.'" style="display:none">'."\n";
+
+		$oConfig = MetaModel::GetConfig();
+		$sSectionStateStorageKey = $oConfig->GetItopInstanceid().'/'.$sSectionStateStorageBusinessKey.'/collapsible-'.$iSectionId;
+		$sSectionStateStorageKey = json_encode($sSectionStateStorageKey);
+		$sOpenedByDefault = ($bOpenedByDefault) ? 'true' : 'false';
+		$this->add_ready_script("initCollapsibleSection($iSectionId, $sOpenedByDefault, '$sSectionStateStorageKey');");
+
 		$iSectionId++;
 		return $sHtml;
 	}
diff --git a/core/config.class.inc.php b/core/config.class.inc.php
index b5286f339..54c941ad1 100644
--- a/core/config.class.inc.php
+++ b/core/config.class.inc.php
@@ -1086,6 +1086,18 @@ class Config
 		return (array_key_exists($sPropCode, $this->m_aSettings));
 	}
 
+	/**
+	 * @return string identifier that can be used for example to name WebStorage/SessionStorage keys (they
+	 *     are related to a whole domain, and a domain can host multiple itop)
+	 */
+	public function GetItopInstanceid()
+	{
+		return utils::GetAbsoluteUrlAppRoot()
+			.'==='.$this->Get('db_host')
+			.'/'.$this->Get('db_name')
+			.'/'.$this->Get('db_subname');
+	}
+
 	public function GetDescription($sPropCode)
 	{
 		return $this->m_aSettings[$sPropCode];
diff --git a/pages/notifications.php b/pages/notifications.php
index 22468f25f..093b76b3c 100644
--- a/pages/notifications.php
+++ b/pages/notifications.php
@@ -44,7 +44,7 @@ $oP->add('</div>');
 
 $oP->SetBreadCrumbEntry('ui-tool-notifications', Dict::S('Menu:NotificationsMenu'), Dict::S('Menu:NotificationsMenu+'), '', '../images/bell.png');
 
-$oP->StartCollapsibleSection(Dict::S('UI:NotificationsMenu:Help'), true);
+$oP->StartCollapsibleSection(Dict::S('UI:NotificationsMenu:Help'), true, 'notifications-home');
 $oP->add('<div style="padding: 1em; font-size:10pt;background:#E8F3CF;margin-top: 0.25em;">');
 $oP->add('<img src="../images/bell.png" style="margin-top: -60px; margin-right: 10px; float: right;">');
 $oP->add(Dict::S('UI:NotificationsMenu:HelpContent'));
diff --git a/pages/run_query.php b/pages/run_query.php
index 188272c76..8542cbd56 100644
--- a/pages/run_query.php
+++ b/pages/run_query.php
@@ -225,7 +225,7 @@ EOF
 		$oP->SetBreadCrumbEntry($sPageId, $sLabel, $oFilter->ToOQL(true), $sUrl, '../images/breadcrumb-search.png');
 
 		$oP->p('');
-		$oP->StartCollapsibleSection(Dict::S('UI:RunQuery:MoreInfo'), false);
+		$oP->StartCollapsibleSection(Dict::S('UI:RunQuery:MoreInfo'), false, 'runQuery');
 		$oP->p(Dict::S('UI:RunQuery:DevelopedQuery').htmlentities($oFilter->ToOQL(), ENT_QUOTES, 'UTF-8'));
 		$oP->p(Dict::S('UI:RunQuery:SerializedFilter').$oFilter->serialize());
 		$oP->EndCollapsibleSection();