composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-13 07:24:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge remote-tracking branch 'origin/support/3.0' into develop

Browse Source 
# Conflicts:
#	sources/Core/Email/EmailSwiftMailer.php
#	tests/php-unit-tests/integration-tests/DictionariesConsistencyTest.php
#	tests/php-unit-tests/postbuild_integration.xml.dist
This commit is contained in:
Pierre Goiffon
2023-07-06 17:11:10 +02:00
parent a2a0b2cd0b a010239efb
commit ef0b0f88c9
4 changed files with 34 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
datamodels/2.x/itop-oauth-client/datamodel.itop-oauth-client.xml
View File

@@ -230,6 +230,7 @@ HTML
$this->Set('refresh_token', $oAccessToken->getRefreshToken()); $this->Set('refresh_token', $oAccessToken->getRefreshToken());
} }
$this->Set('status', 'active'); $this->Set('status', 'active');
$this->AllowWrite();
$this->DBUpdate(); $this->DBUpdate();
} }
]]></code> ]]></code>

17
datamodels/2.x/itop-oauth-client/src/Controller/AjaxOauthClientController.php
View File

@@ -11,6 +11,7 @@ use Combodo\iTop\Application\TwigBase\Controller\Controller;
use Combodo\iTop\Core\Authentication\Client\OAuth\OAuthClientProviderFactory; use Combodo\iTop\Core\Authentication\Client\OAuth\OAuthClientProviderFactory;
use Dict; use Dict;
use IssueLog; use IssueLog;
use League\OAuth2\Client\Provider\Exception\IdentityProviderException;
use MetaModel; use MetaModel;
use utils; use utils;
use WebPage; use WebPage;
@@ -65,13 +66,15 @@ class AjaxOauthClientController extends Controller
} }
if (isset($aQuery['code'])) { if (isset($aQuery['code'])) {
$sCode = $aQuery['code']; $sCode = $aQuery['code'];
$oAccessToken = OAuthClientProviderFactory::GetAccessTokenFromCode($oOAuthClient, $sCode); try {
$oAccessToken = OAuthClientProviderFactory::GetAccessTokenFromCode($oOAuthClient, $sCode);
$oOAuthClient->SetAccessToken($oAccessToken); $oOAuthClient->SetAccessToken($oAccessToken);
$aResult['status'] = 'success';
}
catch (IdentityProviderException $e) {
$aResult['status'] = 'success'; $aResult['status'] = 'error';
$aResult['error_description'] = $e->getMessage();
}
} }
} else { } else {
$aResult['status'] = 'error'; $aResult['status'] = 'error';

23
setup/backup.class.inc.php
View File

@@ -358,6 +358,7 @@ class DBBackup
$sPortOption = self::GetMysqliCliSingleOption('port', $this->iDBPort); $sPortOption = self::GetMysqliCliSingleOption('port', $this->iDBPort);
$sTlsOptions = self::GetMysqlCliTlsOptions($this->oConfig); $sTlsOptions = self::GetMysqlCliTlsOptions($this->oConfig);
$sProtocolOption = self::GetMysqlCliTransportOption($this->sDBHost);
$sMysqlVersion = CMDBSource::GetDBVersion(); $sMysqlVersion = CMDBSource::GetDBVersion();
$bIsMysqlSupportUtf8mb4 = (version_compare($sMysqlVersion, self::MYSQL_VERSION_WITH_UTF8MB4_IN_PROGRAMS) === -1); $bIsMysqlSupportUtf8mb4 = (version_compare($sMysqlVersion, self::MYSQL_VERSION_WITH_UTF8MB4_IN_PROGRAMS) === -1);
@@ -378,8 +379,8 @@ EOF;
// Note: opt implicitely sets lock-tables... which cancels the benefit of single-transaction! // Note: opt implicitely sets lock-tables... which cancels the benefit of single-transaction!
// skip-lock-tables compensates and allows for writes during a backup // skip-lock-tables compensates and allows for writes during a backup
$sCommand = "$sMySQLDump --defaults-extra-file=\"$sMySQLDumpCnfFile\" --opt --skip-lock-tables --default-character-set=".$sMysqldumpCharset." --add-drop-database --single-transaction --host=$sHost $sPortOption --user=$sUser $sTlsOptions --result-file=$sTmpFileName $sDBName $sTables 2>&1"; $sCommand = "$sMySQLDump --defaults-extra-file=\"$sMySQLDumpCnfFile\" --opt --skip-lock-tables --default-character-set=".$sMysqldumpCharset." --add-drop-database --single-transaction --host=$sHost $sPortOption $sProtocolOption --user=$sUser $sTlsOptions --result-file=$sTmpFileName $sDBName $sTables 2>&1";
$sCommandDisplay = "$sMySQLDump --defaults-extra-file=\"$sMySQLDumpCnfFile\" --opt --skip-lock-tables --default-character-set=".$sMysqldumpCharset." --add-drop-database --single-transaction --host=$sHost $sPortOption --user=xxxxx $sTlsOptions --result-file=$sTmpFileName $sDBName $sTables"; $sCommandDisplay = "$sMySQLDump --defaults-extra-file=\"$sMySQLDumpCnfFile\" --opt --skip-lock-tables --default-character-set=".$sMysqldumpCharset." --add-drop-database --single-transaction --host=$sHost $sPortOption $sProtocolOption --user=xxxxx $sTlsOptions --result-file=$sTmpFileName $sDBName $sTables";
// Now run the command for real // Now run the command for real
$this->LogInfo("backup: generate data file with command: $sCommandDisplay"); $this->LogInfo("backup: generate data file with command: $sCommandDisplay");
@@ -576,6 +577,24 @@ EOF;
return ' --'.$sCliArgName.'='.self::EscapeShellArg($sData); return ' --'.$sCliArgName.'='.self::EscapeShellArg($sData);
} }
/**
* @param string $sHost
*
* @return string .
* @since 2.7.9 3.0.4 3.1.1 N°6123
*/
public static function GetMysqlCliTransportOption(string $sHost)
{
$sTransportOptions = '';
if($sHost === 'localhost'){
$sTransportOptions = '--protocol=tcp';
}
return $sTransportOptions;
}
/** /**
* @return string the command to launch mysqldump (without its params) * @return string the command to launch mysqldump (without its params)
*/ */

3
sources/Core/Authentication/Client/OAuth/OAuthClientProviderFactory.php
View File

@@ -74,6 +74,7 @@ class OAuthClientProviderFactory
* @return AccessTokenInterface * @return AccessTokenInterface
* @throws \ArchivedObjectException * @throws \ArchivedObjectException
* @throws \CoreException * @throws \CoreException
* @throws \League\OAuth2\Client\Provider\Exception\IdentityProviderException
*/ */
public static function GetAccessTokenFromCode(OAuthClient $oOAuthClient, $sCode) public static function GetAccessTokenFromCode(OAuthClient $oOAuthClient, $sCode)
{ {
@@ -109,7 +110,7 @@ class OAuthClientProviderFactory
/** /**
* @param \DBObject $oOAuthClient * @param \DBObject $oOAuthClient
* *
* @return mixed * @return OAuthClientProviderAbstract
* @throws \ArchivedObjectException * @throws \ArchivedObjectException
* @throws \CoreException * @throws \CoreException
*/ */