From eac6f07823b6621ff80b3723dd3de5181755a059 Mon Sep 17 00:00:00 2001 From: Molkobain Date: Tue, 17 May 2022 16:46:42 +0200 Subject: [PATCH] =?UTF-8?q?N=C2=B04985=20-=20PHP=208.0:=20Fix=20optional?= =?UTF-8?q?=20parameter=20before=20mandatory=20parameter?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Method is always (once) called with the value defined in iTop * No Combodo extension call the method * No customization in the ITSM Designer (snippets / extensions) call the method * Calling method with only the first parameter would crash anyway --- core/displayablegraph.class.inc.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/displayablegraph.class.inc.php b/core/displayablegraph.class.inc.php index 66cd7e660d..a39a1a0fc1 100644 --- a/core/displayablegraph.class.inc.php +++ b/core/displayablegraph.class.inc.php @@ -1203,8 +1203,10 @@ class DisplayableGraph extends SimpleGraph * @param float $xMax Right coordinate of the bounding box to display the graph * @param float $yMin Top coordinate of the bounding box to display the graph * @param float $yMax Bottom coordinate of the bounding box to display the graph + * + * @since 2.7.7 3.0.2 3.1.0 N°4985 $sComments param is no longer optional */ - function RenderAsPDF(PDFPage $oPage, $sComments = '', $sContextKey, $xMin = -1, $xMax = -1, $yMin = -1, $yMax = -1) + function RenderAsPDF(PDFPage $oPage, $sComments, $sContextKey, $xMin = -1, $xMax = -1, $yMin = -1, $yMax = -1) { $aContextDefs = static::GetContextDefinitions($sContextKey, false); // No need to develop the parameters $oPdf = $oPage->get_tcpdf();