From e44523e62358a2638247524c27ae63bc006997c5 Mon Sep 17 00:00:00 2001 From: Molkobain Date: Tue, 9 Aug 2022 17:45:31 +0200 Subject: [PATCH] =?UTF-8?q?N=C2=B05343=20-=20Avoid=20crash=20when=201=20le?= =?UTF-8?q?vel=20menu=20group=20is=20not=20actually=20a=20MenuGroup=20(#31?= =?UTF-8?q?2)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- application/menunode.class.inc.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/application/menunode.class.inc.php b/application/menunode.class.inc.php index 2e71abbc3..b4db18ae0 100644 --- a/application/menunode.class.inc.php +++ b/application/menunode.class.inc.php @@ -265,6 +265,14 @@ class ApplicationMenu /** @var \MenuGroup $oMenuNode */ $oMenuNode = static::GetMenuNode($sMenuGroupIdx); + if (!($oMenuNode instanceof MenuGroup)) { + IssueLog::Error('Menu node was not displayed as a menu group as it is actually not a menu group', LogChannels::CONSOLE, [ + 'menu_node_class' => get_class($oMenuNode), + 'menu_node_label' => $oMenuNode->GetLabel(), + ]); + continue; + } + $aMenuGroups[] = [ 'sId' => $oMenuNode->GetMenuID(), 'sIconCssClasses' => $oMenuNode->GetDecorationClasses(),