composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-03-10 11:34:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

Button factory: Fix name param. being mandatory on some methods

Browse Source
This commit is contained in:
Molkobain
2021-03-24 23:57:30 +01:00
parent a5a771b242
commit e0a655e102
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
sources/application/UI/Base/Component/Button/ButtonUIBlockFactory.php
View File

@@ -45,16 +45,20 @@ class ButtonUIBlockFactory extends AbstractUIBlockFactory
* Make a basis Button component for any purpose
*
* @param string $sLabel
* @param string $sName See {@link Button::$sName}
* @param string|null $sName See {@link Button::$sName}
* @param string|null $sId
*
* @return \Combodo\iTop\Application\UI\Base\Component\Button\Button
*/
public static function MakeNeutral(string $sLabel, string $sName, ?string $sId = null): Button {
public static function MakeNeutral(string $sLabel, string $sName = null, ?string $sId = null): Button
{
$oButton = new ButtonJS($sLabel, $sId);
$oButton->SetActionType(Button::ENUM_ACTION_TYPE_REGULAR)
->SetColor(Button::ENUM_COLOR_NEUTRAL)
->SetName($sName);
->SetColor(Button::ENUM_COLOR_NEUTRAL);
if (!empty($sName)) {
$oButton->SetName($sName);
}
return $oButton;
}
@@ -152,17 +156,17 @@ class ButtonUIBlockFactory extends AbstractUIBlockFactory
/**
* Make a basis Button component for any purpose
*
* @param string $sLabel
* @param string $sName See Button::$sName
* @param string $sLabel
* @param string|null $sName See Button::$sName
* @param string|null $sValue See Button::$sValue
* @param bool $bIsSubmit See Button::$sType
* @param bool $bIsSubmit See Button::$sType
* @param string|null $sId
*
* @return \Combodo\iTop\Application\UI\Base\Component\Button\Button
*/
public static function MakeAlternativeNeutral(
string $sLabel,
string $sName,
string $sName = null,
string $sValue = null,
bool $bIsSubmit = false,
?string $sId = null