From dad406d208beb11ae3c0b43dcf1ec03189bed4da Mon Sep 17 00:00:00 2001
From: Molkobain <lajarige.guillaume@free.fr>
Date: Fri, 12 Apr 2024 10:50:59 +0200
Subject: [PATCH] =?UTF-8?q?N=C2=B06964=20-=20Improve=20PHPDoc=20and=20meth?=
 =?UTF-8?q?od=20name=20to=20explicit=20that=20paths=20are=20relative?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 application/applicationextension.inc.php                   | 7 ++-----
 setup/backup.class.inc.php                                 | 2 +-
 .../Delta/application-extension-usages-in-snippets.xml     | 2 +-
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/application/applicationextension.inc.php b/application/applicationextension.inc.php
index 915eda70d..e5ef39465 100644
--- a/application/applicationextension.inc.php
+++ b/application/applicationextension.inc.php
@@ -2292,11 +2292,8 @@ interface iKPILoggerExtension
 interface iBackupExtraFilesExtension
 {
 	/**
-	 * Returns an array of files and directories to be included in the backup
-	 *
 	 * @api
-	 *
-	 * @return string[]
+	 * @return string[] Array of relative paths (from app root) for files and directories to be included in the backup
 	 */
-	public function GetExtraFiles(): array;
+	public function GetExtraFilesRelPaths(): array;
 }
diff --git a/setup/backup.class.inc.php b/setup/backup.class.inc.php
index 43c0aeeb8..127f953ea 100644
--- a/setup/backup.class.inc.php
+++ b/setup/backup.class.inc.php
@@ -276,7 +276,7 @@ class DBBackup
 		{
 			/** @var iBackupExtraFilesExtension $oExtensionInstance */
 			$oExtensionInstance = new $sExtensionClass();
-			$aExtraFiles = array_merge($aExtraFiles, $oExtensionInstance->GetExtraFiles());
+			$aExtraFiles = array_merge($aExtraFiles, $oExtensionInstance->GetExtraFilesRelPaths());
 		}
 
 		foreach($aExtraFiles as $sExtraFileOrDir)
diff --git a/tests/php-unit-tests/unitary-tests/application/applicationextension/Delta/application-extension-usages-in-snippets.xml b/tests/php-unit-tests/unitary-tests/application/applicationextension/Delta/application-extension-usages-in-snippets.xml
index beaadac93..631d3d45c 100644
--- a/tests/php-unit-tests/unitary-tests/application/applicationextension/Delta/application-extension-usages-in-snippets.xml
+++ b/tests/php-unit-tests/unitary-tests/application/applicationextension/Delta/application-extension-usages-in-snippets.xml
@@ -359,7 +359,7 @@ class ExampleFor_iKPILoggerExtension implements \iKPILoggerExtension
       <content><![CDATA[
 class ExampleFor_iBackupExtraFilesExtension implements \iBackupExtraFilesExtension
 {
-	public function GetExtraFiles(): array
+	public function GetExtraFilesRelPaths(): array
 	{
 		return [
 		  'foo'