From daa906a697afcfb8d42709bbde721fe384015c7b Mon Sep 17 00:00:00 2001
From: Thomas Casteleyn <thomas.casteleyn@me.com>
Date: Mon, 10 Jun 2019 11:28:24 +0200
Subject: [PATCH] Only set Ticket ref if not yet present via import or synchro
 (#82)

New non blocking uniqueness rule on Ticket.ref to warn when having ref duplicates
---
 datamodels/2.x/itop-tickets/datamodel.itop-tickets.xml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/datamodels/2.x/itop-tickets/datamodel.itop-tickets.xml b/datamodels/2.x/itop-tickets/datamodel.itop-tickets.xml
index 4564034f5..2c9765a2d 100755
--- a/datamodels/2.x/itop-tickets/datamodel.itop-tickets.xml
+++ b/datamodels/2.x/itop-tickets/datamodel.itop-tickets.xml
@@ -53,6 +53,14 @@
 				   </attributes>
 				 </index>
 				</indexes>
+				<uniqueness_rules>
+					<rule if="ref">
+						<attributes>
+							<attribute id="ref"/>
+						</attributes>
+						<is_blocking>false</is_blocking>
+					</rule>
+				</uniqueness_rules>
 			</properties>
 			<fields>
 				<field id="operational_status" xsi:type="AttributeMetaEnum">
@@ -209,7 +217,7 @@
           $oMutex->Lock();
           $iNextId = MetaModel::GetNextKey(get_class($this));
           $sRef = $this->MakeTicketRef($iNextId);
-          $this->Set('ref', $sRef);
+          $this->SetIfNull('ref', $sRef);
           $iKey = parent::DBInsertNoReload();
           $oMutex->Unlock();
           return $iKey;