composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-12 23:14:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix appUserPreferences type hinting as it accepts more than just strings

Browse Source
This commit is contained in:
Molkobain
2020-07-23 15:50:13 +02:00
parent 6a3bbd8d49
commit da5d55a542
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
application/user.preferences.class.inc.php
View File

@@ -39,11 +39,13 @@ class appUserPreferences extends DBObject
/**
* Get the value of the given property/preference
* If not set, the default value will be returned
*
* @param string $sCode Code/Name of the property to set
* @param string $sDefaultValue The default value
* @return string The value of the property for the current user
* @param mixed $defaultValue The default value
*
* @return mixed The value of the property for the current user
*/
public static function GetPref($sCode, $sDefaultValue)
public static function GetPref($sCode, $defaultValue)
{
if (self::$oUserPrefs == null)
{
@@ -56,29 +58,30 @@ class appUserPreferences extends DBObject
}
else
{
return $sDefaultValue;
return $defaultValue;
}
}
/**
* Set the value for a given preference, and stores it into the database
*
* @param string $sCode Code/Name of the property/preference to set
* @param string $sValue Value to set
* @param mixed $value Value to set
*/
public static function SetPref($sCode, $sValue)
public static function SetPref($sCode, $value)
{
if (self::$oUserPrefs == null)
{
self::Load();
}
$aPrefs = self::$oUserPrefs->Get('preferences');
if (array_key_exists($sCode, $aPrefs) && ($aPrefs[$sCode] === $sValue))
if (array_key_exists($sCode, $aPrefs) && ($aPrefs[$sCode] === $value))
{
// Do not write it again
}
else
{
$aPrefs[$sCode] = $sValue;
$aPrefs[$sCode] = $value;
self::$oUserPrefs->Set('preferences', $aPrefs);
self::Save();
}