From da4f112858424c5226ea159914d8b803dddced30 Mon Sep 17 00:00:00 2001 From: Benjamin Dalsass Date: Mon, 20 Nov 2023 16:40:16 +0100 Subject: [PATCH] =?UTF-8?q?N=C2=B06933=20-=20SF=206.4=20-=20Remove=20depre?= =?UTF-8?q?cated=20calls=20-=20SessionMessageController=20(services=20acce?= =?UTF-8?q?ss)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../Controller/SessionMessageController.php | 21 ++++++++++++------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/datamodels/2.x/itop-portal-base/portal/src/Controller/SessionMessageController.php b/datamodels/2.x/itop-portal-base/portal/src/Controller/SessionMessageController.php index 38a5ae20dc..ea1cbcf8e0 100644 --- a/datamodels/2.x/itop-portal-base/portal/src/Controller/SessionMessageController.php +++ b/datamodels/2.x/itop-portal-base/portal/src/Controller/SessionMessageController.php @@ -20,6 +20,8 @@ namespace Combodo\iTop\Portal\Controller; +use Combodo\iTop\Portal\Helper\RequestManipulatorHelper; +use Combodo\iTop\Portal\Helper\SessionMessageHelper; use Symfony\Component\HttpFoundation\JsonResponse; use Symfony\Component\HttpFoundation\Request; use Symfony\Component\HttpFoundation\Response; @@ -34,6 +36,14 @@ use Symfony\Component\HttpKernel\Exception\HttpException; */ class SessionMessageController extends AbstractController { + + public function __construct( + protected RequestManipulatorHelper $oRequestManipulator, + protected SessionMessageHelper $oSessionManagerHelper + ) + { + } + /** * @param \Symfony\Component\HttpFoundation\Request $oRequest * @@ -43,14 +53,9 @@ class SessionMessageController extends AbstractController { $aData = array(); - /** @var \Combodo\iTop\Portal\Helper\RequestManipulatorHelper $oRequestManipulator */ - $oRequestManipulator = $this->get('request_manipulator'); - /** @var \Combodo\iTop\Portal\Helper\SessionMessageHelper $oSessionMessageHelper */ - $oSessionMessageHelper = $this->get('session_message_helper'); - // Retrieve parameters - $sMessageSeverity = $oRequestManipulator->ReadParam('sSeverity'); - $sMessageContent = $oRequestManipulator->ReadParam('sContent'); + $sMessageSeverity = $this->oRequestManipulator->ReadParam('sSeverity'); + $sMessageContent = $this->oRequestManipulator->ReadParam('sContent'); // Check parameters consistency if (empty($sMessageSeverity) || empty($sMessageContent)) @@ -59,7 +64,7 @@ class SessionMessageController extends AbstractController } // Add message - $oSessionMessageHelper->AddMessage(uniqid(), $sMessageContent, $sMessageSeverity); + $this->oSessionMessageHelper->AddMessage(uniqid(), $sMessageContent, $sMessageSeverity); return new JsonResponse($aData); }