From d7ef9acf1aee57307f16f00554fb02b798cac527 Mon Sep 17 00:00:00 2001
From: v-dumas <vincent.dumas@combodo.com>
Date: Fri, 29 May 2026 17:18:41 +0200
Subject: [PATCH] =?UTF-8?q?N=C2=B09160=20-=20Refactor=20UpdateChildxxxxxLo?=
 =?UTF-8?q?g=20and=20test?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../datamodel.itop-incident-mgmt-itil.xml            |  4 ++--
 .../datamodel.itop-request-mgmt-itil.xml             | 12 +++++++++++-
 .../datamodel.itop-request-mgmt.xml                  |  5 +----
 3 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/datamodels/2.x/itop-incident-mgmt-itil/datamodel.itop-incident-mgmt-itil.xml b/datamodels/2.x/itop-incident-mgmt-itil/datamodel.itop-incident-mgmt-itil.xml
index dfa5fe979..663ba74ff 100755
--- a/datamodels/2.x/itop-incident-mgmt-itil/datamodel.itop-incident-mgmt-itil.xml
+++ b/datamodels/2.x/itop-incident-mgmt-itil/datamodel.itop-incident-mgmt-itil.xml
@@ -1317,7 +1317,7 @@
           <code><![CDATA[	public function UpdateChildRequestLog()
 	{
     if (MetaModel::IsValidClass('UserRequest')) {
-        return parent::UpdateChildTicketLog('UserRequest', 'parent_request_id', ['public_log', 'private_log']);
+        return $this->UpdateChildTicketLog('UserRequest', 'parent_incident_id', ['public_log' => 'public_log', 'private_log' => 'private_log'] );
     }
     return true;
 	}]]></code>
@@ -1329,7 +1329,7 @@
           <type>LifecycleAction</type>
           <code><![CDATA[	public function UpdateChildIncidentLog()
 	{
-	  return parent::UpdateChildTicketLog('Incident', 'parent_incident_id', ['public_log', 'private_log']);
+	  return $this->UpdateChildTicketLog('Incident', 'parent_incident_id', ['public_log' => 'public_log', 'private_log' => 'private_log']);
 	}]]></code>
         </method>
         <method id="ComputeImpactedItems">
diff --git a/datamodels/2.x/itop-request-mgmt-itil/datamodel.itop-request-mgmt-itil.xml b/datamodels/2.x/itop-request-mgmt-itil/datamodel.itop-request-mgmt-itil.xml
index 234720260..9169fe93e 100755
--- a/datamodels/2.x/itop-request-mgmt-itil/datamodel.itop-request-mgmt-itil.xml
+++ b/datamodels/2.x/itop-request-mgmt-itil/datamodel.itop-request-mgmt-itil.xml
@@ -1452,8 +1452,17 @@
           <type>LifecycleAction</type>
           <code><![CDATA[	public function UpdateChildRequestLog()
 {
-    return parent::UpdateChildTicketLog('UserRequest', 'parent_request_id', ['public_log', 'private_log']);
+    return $this->UpdateChildTicketLog('UserRequest', 'parent_request_id', ['public_log' => 'public_log', 'private_log' => 'private_log' ]);
 }]]></code>
+        </method>
+        <method id="UpdateChildIncidentLog">
+          <static>false</static>
+          <access>public</access>
+          <type>LifecycleAction</type>
+          <code><![CDATA[	public function UpdateChildIncidentLog()
+	{
+	  return $this->UpdateChildTicketLog('Incident', 'parent_request_id', ['public_log' => 'public_log', 'private_log' => 'private_log']);
+	}]]></code>
         </method>
         <method id="ComputeImpactedItems">
           <static>false</static>
@@ -1490,6 +1499,7 @@
         parent::OnUpdate();
 		$this->Set('last_update', time());
 		$this->UpdateChildRequestLog();
+		$this->UpdateChildIncidentLog();
 	}]]></code>
         </method>
       </methods>
diff --git a/datamodels/2.x/itop-request-mgmt/datamodel.itop-request-mgmt.xml b/datamodels/2.x/itop-request-mgmt/datamodel.itop-request-mgmt.xml
index 9fbe0569a..97025b581 100755
--- a/datamodels/2.x/itop-request-mgmt/datamodel.itop-request-mgmt.xml
+++ b/datamodels/2.x/itop-request-mgmt/datamodel.itop-request-mgmt.xml
@@ -1487,10 +1487,7 @@
           <type>LifecycleAction</type>
           <code><![CDATA[	public function UpdateChildRequestLog()
 {
-    return $this->UpdateChildTicketLog('UserRequest', 'parent_request_id',
-        ['public_log' => 'public_log',
-        'private_log' => 'private_log',
-        ]);
+        return $this->UpdateChildTicketLog('UserRequest', 'parent_request_id', ['public_log' => 'public_log', 'private_log' => 'private_log'] );
 	}]]></code>
         </method>
         <method id="ComputeImpactedItems">