diff --git a/core/inlineimage.class.inc.php b/core/inlineimage.class.inc.php index 54d839c85..ec71d82a0 100644 --- a/core/inlineimage.class.inc.php +++ b/core/inlineimage.class.inc.php @@ -362,13 +362,8 @@ class InlineImage extends DBObject { $sJS = << {$iMaxWidth}) - { - $(this).css({'max-width': '{$iMaxWidth}px', width: '', height: '', 'max-height': ''}); - } - $(this).addClass('inline-image').attr('href', $(this).attr('src')); -}).magnificPopup({type: 'image', closeOnContentClick: true }); +CombodoInlineImage.SetMaxWidth('{$iMaxWidth}'); +CombodoInlineImage.FixImagesWidth(); JS ; } diff --git a/js/layouts/activity-panel/activity-panel.js b/js/layouts/activity-panel/activity-panel.js index e1fe8183f..f526b9ca4 100644 --- a/js/layouts/activity-panel/activity-panel.js +++ b/js/layouts/activity-panel/activity-panel.js @@ -928,6 +928,9 @@ $(function() } me._ApplyEntriesFilters(); + // Try to fix inline images width + CombodoInlineImage.FixImagesWidth(); + // For now, we don't hide the forms as the user may want to add something else me.element.find(me.js_selectors.caselog_entry_form).trigger('clear_entry.caselog_entry_form.itop'); diff --git a/js/utils.js b/js/utils.js index 22b8ac862..1424d01c4 100644 --- a/js/utils.js +++ b/js/utils.js @@ -986,8 +986,6 @@ const CombodoJSConsole = { } } - - /** * Helper to Sanitize string * @@ -1079,4 +1077,33 @@ const CombodoSanitizer = { return sEncodedValue; } -}; \ No newline at end of file +}; + +/** + * Helper for InlineImages + * @since 3.0.0 + */ +const CombodoInlineImage = { + /** + * Max width to apply on inline images + */ + max_width: 600, + /** + * @param sMaxWidth {string} {@see CombodoInlineImage.max_width} + */ + SetMaxWidth: function (sMaxWidth) { + this.max_width = sMaxWidth; + }, + /** + * Apply the {@see CombodoInlineImage.max_width} to all inline images + */ + FixImagesWidth: function () { + $('img[data-img-id]').each(function() { + if ($(this).width() > CombodoInlineImage.max_width) + { + $(this).css({'max-width': CombodoInlineImage.max_width+'px', width: '', height: '', 'max-height': ''}); + } + $(this).addClass('inline-image').attr('href', $(this).attr('src')); + }).magnificPopup({type: 'image', closeOnContentClick: true }); + } +} \ No newline at end of file