diff --git a/sources/Service/Import/CSVImportPageProcessor.php b/sources/Service/Import/CSVImportPageProcessor.php index 1f75fa963..1c8f53c4b 100644 --- a/sources/Service/Import/CSVImportPageProcessor.php +++ b/sources/Service/Import/CSVImportPageProcessor.php @@ -592,6 +592,7 @@ EOF */ private static function GetDivAlert(string $message): string { + $message = utils::EscapeHtml($message); return "
$message
\n"; } diff --git a/tests/php-unit-tests/src/Service/UnitTestRunTimeEnvironment.php b/tests/php-unit-tests/src/Service/UnitTestRunTimeEnvironment.php index 7cbe20215..478bf27fa 100644 --- a/tests/php-unit-tests/src/Service/UnitTestRunTimeEnvironment.php +++ b/tests/php-unit-tests/src/Service/UnitTestRunTimeEnvironment.php @@ -102,6 +102,7 @@ class UnitTestRunTimeEnvironment extends RunTimeEnvironment $aTestDirs = array_merge($aTestDirs, glob(APPROOT.$sRoot.'tests', GLOB_ONLYDIR)); } + $aLoadedTestClasses = []; foreach($aTestDirs as $sTestDir) { // Iterate on all PHP files in subdirectories // Note: grep is not available on Windows, so we will use the PHP Reflection API @@ -129,10 +130,11 @@ class UnitTestRunTimeEnvironment extends RunTimeEnvironment if ($sClass === '') { continue; } - if (class_exists($sClass)) { + if (in_array($sClass, $aLoadedTestClasses)) { echo "class $sClass already loaded somehow \n"; continue; } + $aLoadedTestClasses[]=$sClass; require_once $sFile; $oReflectionClass = new ReflectionClass($sClass); if ($oReflectionClass->isAbstract()) { diff --git a/tests/php-unit-tests/unitary-tests/core/BulkChangeTest.php b/tests/php-unit-tests/unitary-tests/core/BulkChangeTest.php index 7ca006bfa..7d401b63d 100644 --- a/tests/php-unit-tests/unitary-tests/core/BulkChangeTest.php +++ b/tests/php-unit-tests/unitary-tests/core/BulkChangeTest.php @@ -101,13 +101,14 @@ class BulkChangeTest extends ItopDataTestCase //$this->debug("sStatus:".$sStatus->GetDescription()); $this->assertEquals($aResult["__STATUS__"], $sStatus->GetDescription()); foreach ($aRow as $i => $oCell) { + /** @var $oCell \CellChangeSpec */ if ($i !== "finalclass" && $i !== "__STATUS__" && $i !== "__ERRORS__" && array_key_exists($i, $aResult)) { $this->debug("i:".$i); $this->debug('GetCLIValue:'.$oCell->GetCLIValue()); $this->debug("aResult:".$aResult[$i]); - $this->assertEquals($aResult[$i], $oCell->GetCLIValue()); + $this->assertEquals($aResult[$i], $oCell->GetCLIValue(), "Unexpected CLI result for cell " . $i); if (null !== $aResultHTML) { - $this->assertEquals($aResultHTML[$i], $oCell->GetHTMLValue()); + $this->assertEquals($aResultHTML[$i], $oCell->GetHTMLValue(), "Unexpected HTML result for cell " . $i); } } }