composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-05-01 06:28:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°2847 - Refactor some early choices

Browse Source 
- TWIG: Change calls to object methods from simple notation (eg. oObject.Id) to complete notation (eg. oObject.GetId()) to avoid confusion with use of arrays and variables (eg. aObject.sId)
- UIBlock: $sId should not be first parameter as most of the time it can be ignored and generated by the system
- NewsroomMenu: Rename method for something more less ambiguous
- Html: Embed content in <div /> so we can easily find all such HTML fragments in the UI
This commit is contained in:
Molkobain
2020-08-21 13:07:07 +02:00
parent 5320f69c44
commit d2bf4de84c
24 changed files with 94 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sources/application/UI/Layout/TopBar/TopBarFactory.php
View File

@@ -47,21 +47,21 @@ class TopBarFactory
*/
public static function MakeStandard($aBreadcrumbsEntry = null)
{
$oTopBar = new TopBar(TopBar::BLOCK_CODE);
$oTopBar = new TopBar(TopBar::BLOCK_CODE);
if(utils::GetConfig()->Get('quick_create.enabled') === true)
if (utils::GetConfig()->Get('quick_create.enabled') === true)
{
$oTopBar->SetQuickCreate(QuickCreateFactory::MakeFromUserHistory());
}
if(utils::GetConfig()->Get('global_search.enabled') === true)
if (utils::GetConfig()->Get('global_search.enabled') === true)
{
$oTopBar->SetGlobalSearch(GlobalSearchFactory::MakeFromUserHistory());
}
if(utils::GetConfig()->Get('breadcrumb.enabled') === true)
{
$oBreadcrumbs = new Breadcrumbs(Breadcrumbs::BLOCK_CODE, $aBreadcrumbsEntry);
$oBreadcrumbs = new Breadcrumbs($aBreadcrumbsEntry, Breadcrumbs::BLOCK_CODE);
$oTopBar->SetBreadcrumbs($oBreadcrumbs);
}