mirror of
https://github.com/Combodo/iTop.git
synced 2026-04-23 18:48:51 +02:00
N°2847 - Refactor some early choices
- TWIG: Change calls to object methods from simple notation (eg. oObject.Id) to complete notation (eg. oObject.GetId()) to avoid confusion with use of arrays and variables (eg. aObject.sId) - UIBlock: $sId should not be first parameter as most of the time it can be ignored and generated by the system - NewsroomMenu: Rename method for something more less ambiguous - Html: Embed content in <div /> so we can easily find all such HTML fragments in the UI
This commit is contained in:
@@ -47,12 +47,12 @@ class Alert extends UIBlock
|
||||
/**
|
||||
* Alert constructor.
|
||||
*
|
||||
* @param string $sId
|
||||
* @param string $sTitle
|
||||
* @param string $sMainText
|
||||
* @param string $sColor
|
||||
* @param string|null $sId
|
||||
*/
|
||||
public function __construct($sId, $sTitle = '', $sMainText = '', $sColor = 'secondary')
|
||||
public function __construct($sTitle = '', $sMainText = '', $sColor = 'secondary', $sId = null)
|
||||
{
|
||||
$this->sTitle = $sTitle;
|
||||
$this->sMainText = $sMainText;
|
||||
|
||||
Reference in New Issue
Block a user