composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-23 18:48:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°6414 Separate SubFormField and Scalar fields

Browse Source 
This will help to set methods as final, as SubFormField is often the sole one to have a real custom impl
This commit is contained in:
Pierre Goiffon
2023-06-22 14:53:07 +02:00
parent 6606af71ff
commit d085f15b6d
15 changed files with 126 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
sources/Form/Field/SubFormField.php
View File

@@ -19,8 +19,8 @@
namespace Combodo\iTop\Form\Field;
use \Closure;
use \Combodo\iTop\Form\Form;
use Closure;
use Combodo\iTop\Form\Form;
/**
* Description of SubFormField
@@ -29,7 +29,7 @@ use \Combodo\iTop\Form\Form;
*/
class SubFormField extends Field
{
protected $oForm;
protected $oForm;
/**
* @inheritDoc
@@ -61,12 +61,12 @@ class SubFormField extends Field
return $this;
}
/**
* Checks the validators to see if the field's current value is valid.
* Then sets $bValid and $aErrorMessages.
*
* @return boolean
*/
/**
* Checks the validators to see if the field's current value is valid.
* Then sets $bValid and $aErrorMessages.
*
* @inheritDoc
*/
public function Validate()
{
return $this->oForm->Validate();
@@ -124,13 +124,13 @@ class SubFormField extends Field
* @param boolean $bMandatory
*/
public function SetMandatory(bool $bMandatory)
{
foreach ($this->oForm->GetFields() as $oField)
{
$oField->SetMandatory($bMandatory);
}
parent::SetMandatory($bMandatory);
}
{
foreach ($this->oForm->GetFields() as $oField) {
$oField->SetMandatory($bMandatory);
}
return parent::SetMandatory($bMandatory);
}
/**
* Sets the read-only flag on all the fields on the form
@@ -144,7 +144,7 @@ class SubFormField extends Field
$oField->SetReadOnly($bReadOnly);
$oField->SetMandatory(false);
}
parent::SetReadOnly($bReadOnly);
return parent::SetReadOnly($bReadOnly);
}
/**
@@ -158,7 +158,7 @@ class SubFormField extends Field
{
$oField->SetHidden($bHidden);
}
parent::SetHidden($bHidden);
return parent::SetHidden($bHidden);
}
/**