composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-03-06 09:34:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

N°3448 - Framework field size check not correctly implemented for multibytes languages/strings (#528)

Browse Source
This commit is contained in:
Anne-Catherine
2024-01-15 16:10:23 +01:00
committed by GitHub
parent a8cd9566ac
commit cff50f8732
7 changed files with 207 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
tests/php-unit-tests/unitary-tests/core/EventIssueTest.php Normal file
View File

@@ -0,0 +1,69 @@
<?php
use Combodo\iTop\Test\UnitTest\ItopDataTestCase;
class EventIssueTest extends ItopDataTestCase
{
/**
* Data provider for test EventIssue Creation
*
* @return array data
* @since 3.1.2 N°3448 - Framework field size check not correctly implemented for multi-bytes languages/strings
*/
public function OnInsertProvider()
{
return [
'all with ééé' => [
str_repeat('é', 120),
str_repeat('é', 120),
str_repeat('é', 120),
str_repeat('é', 120),
],
'all with 255 smiley' => [
str_repeat('😎', 255),
str_repeat('😎', 255),
str_repeat('😎', 255),
str_repeat('😎', 255),
],
'all with 255 characters, us-ascii only' => [
str_repeat('a', 255),
str_repeat('a', 255),
str_repeat('a', 255),
str_repeat('a', 255),
],
'all with 255 é' => [
str_repeat('é', 255),
str_repeat('é', 255),
str_repeat('é', 255),
str_repeat('é', 255),
],
];
}
/**
* EventIssue has a OnInsert override that uses mb_strlen, so we need to test this specific case
*
* @covers EventIssue::OnInsert
*
* @dataProvider OnInsertProvider
*
* @since 3.1.2 N°3448 - Framework field size check not correctly implemented for multi-bytes languages/strings
*/
public function testOnInsert(string $sIssue, string $sImpact, string $sPage, string $sMessage)
{
$oEventIssue = MetaModel::NewObject('EventIssue', [
'issue' => $sIssue,
'impact' => $sImpact,
'page' => $sPage,
'message' => $sMessage,
]);
try {
$oEventIssue->DBInsert();
}
catch (CoreException $e) {
$this->fail('we should be able to persist the object though it contains long values in its attributes');
}
$this->assertTrue(true);
}
}