N°3416 Updates after code review

Many thanks @bruno-ds !
* add comments to explain intentions
* fix indentations
This commit is contained in:
Pierre Goiffon
2020-12-03 17:38:11 +01:00
parent aa15e009cb
commit cece15d10c
5 changed files with 40 additions and 28 deletions

View File

@@ -64,7 +64,7 @@ try
$oPage->add_header("Cache-Control: no-transform,public,max-age=$iCacheSec,s-maxage=$iCacheSec");
$oPage->add_header("Pragma: cache"); // Reset the value set .... where ?
$oPage->add_header("Expires: "); // Reset the value set in ajax_page
$oPage->add_xframe_options('');
$oPage->add_xframe_options(''); // the header is set in page constructor, we reset its value ! See N°3416
$oPage->add_header("Last-Modified: Wed, 15 Jun 2015 13:21:15 GMT"); // An arbitrary date in the past is ok
}
}
@@ -81,7 +81,7 @@ try
$oPage->add_header("Cache-Control: no-transform,public,max-age=$iCacheSec,s-maxage=$iCacheSec");
$oPage->add_header("Pragma: cache"); // Reset the value set .... where ?
$oPage->add_header("Expires: "); // Reset the value set in ajax_page
$oPage->add_xframe_options('');
$oPage->add_xframe_options(''); // the header is set in page constructor, we reset its value ! See N°3416
$oPage->add_header("Last-Modified: Wed, 15 Jun 2016 13:21:15 GMT"); // An arbitrary date in the past is ok
}
break;
@@ -92,7 +92,7 @@ try
$oPage->SetContentType('text/javascript');
$oPage->add_header('Cache-control: public, max-age=86400'); // Cache for 24 hours
$oPage->add_header("Pragma: cache"); // Reset the value set .... where ?
$oPage->add_xframe_options('');
$oPage->add_xframe_options(''); // the header is set in page constructor, we reset its value ! See N°3416
$oPage->add(file_get_contents(Utils::GetCachePath().$sSignature.'.js'));
break;