From c8fade60136b56dc3df04c8a444fef641904bc4d Mon Sep 17 00:00:00 2001 From: odain Date: Tue, 22 Nov 2022 07:42:03 +0100 Subject: [PATCH] 5620-simplify test to avoid regression in other test sections linked to MetaModel use --- .../UI/Base/Layout/NavigationMenuTest.php | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/test/application/UI/Base/Layout/NavigationMenuTest.php b/test/application/UI/Base/Layout/NavigationMenuTest.php index 1810d9180..ca36ef34a 100644 --- a/test/application/UI/Base/Layout/NavigationMenuTest.php +++ b/test/application/UI/Base/Layout/NavigationMenuTest.php @@ -36,7 +36,7 @@ class NavigationMenuTest extends ItopDataTestCase { $this->assertEquals($bExpectedIsAllowed, $isAllowed); } - public function testIsAllowedWithNoConfVariable(){ + public function testIsAllowed_BackwardCompatibility_NoVariableInConfFile(){ \MetaModel::GetConfig()->Set('navigation_menu.show_organization_filter', false); $sTmpFilePath = tempnam(sys_get_temp_dir(), 'test_'); @@ -57,17 +57,9 @@ class NavigationMenuTest extends ItopDataTestCase { file_put_contents($sTmpFilePath, implode("\n", $aRows)); $oTempConfig = new \Config($sTmpFilePath); - $oReflexionClass = new \ReflectionClass(\MetaModel::class); - $oReflexionClass->setStaticPropertyValue('m_oConfig', $oTempConfig); - - $oNavigationMenu = new NavigationMenu( - $this->createMock(ApplicationContext::class), - $this->createMock(PopoverMenu::class) - ); - - $isAllowed = $oNavigationMenu->IsSiloSelectionEnabled(); - $oReflexionClass->setStaticPropertyValue('m_oConfig', $oInitConfig); + $isAllowed = $oTempConfig->Get('navigation_menu.show_organization_filter'); $this->assertEquals(true, $isAllowed); + unlink($sTmpFilePath); } }