From c4ba1d55ac34385aabbb2baf6fc9644be6cb07c6 Mon Sep 17 00:00:00 2001
From: Pierre Goiffon <pierre.goiffon@combodo.com>
Date: Tue, 11 Dec 2018 10:00:45 +0100
Subject: [PATCH] =?UTF-8?q?:loud=5Fsound:=20N=C2=B01835=20log=20error=20wh?=
 =?UTF-8?q?en=20transaction=5Fid=20invalid=20in=20UI.php?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 pages/UI.php | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/pages/UI.php b/pages/UI.php
index dea8a5acc..146593e09 100644
--- a/pages/UI.php
+++ b/pages/UI.php
@@ -900,6 +900,8 @@ EOF
 			}
 			elseif (!utils::IsTransactionValid($sTransactionId, false))
 			{
+				$sUser = UserRights::GetUser();
+				IssueLog::Error("UI.php '$operation' : invalid transaction_id ! data: user='$sUser', class='$sClass'");
 				$oP->set_title(Dict::Format('UI:ModificationPageTitle_Object_Class', $oObj->GetRawName(), $sClassLabel)); // Set title will take care of the encoding
 				$oP->p("<strong>".Dict::S('UI:Error:ObjectAlreadyUpdated')."</strong>\n");
 			}
@@ -1009,6 +1011,8 @@ EOF
 			$sTransactionId = utils::ReadPostedParam('transaction_id', '', 'transaction_id');
 			if (!utils::IsTransactionValid($sTransactionId))
 			{
+				$sUser = UserRights::GetUser();
+				IssueLog::Error("UI.php '$operation' : invalid transaction_id ! data: user='$sUser', class='$sClass'");
 				throw new ApplicationException(Dict::S('UI:Error:ObjectsAlreadyDeleted'));
 			}
 		// Fall through
@@ -1082,10 +1086,13 @@ EOF
 		}
 		if (!utils::IsTransactionValid($sTransactionId, false))
 		{
+			$sUser = UserRights::GetUser();
+			IssueLog::Error("UI.php '$operation' : invalid transaction_id ! data: user='$sUser', class='$sClass'");
 			$oP->p("<strong>".Dict::S('UI:Error:ObjectAlreadyCreated')."</strong>\n");
 		}
 		else
 		{
+			/** @var \cmdbAbstractObject $oObj */
 			$oObj = MetaModel::NewObject($sClass);
 			$sStateAttCode = MetaModel::GetStateAttributeCode($sClass);
 			if (!empty($sStateAttCode))
@@ -1361,6 +1368,8 @@ EOF
 			$sTransactionId = utils::ReadPostedParam('transaction_id', '', 'transaction_id');
 		if (!utils::IsTransactionValid($sTransactionId))
 		{
+			$sUser = UserRights::GetUser();
+			IssueLog::Error("UI.php '$operation' : invalid transaction_id ! data: user='$sUser', class='$sClass'");
 			$oP->p(Dict::S('UI:Error:ObjectAlreadyUpdated'));
 		}
 		else
@@ -1530,6 +1539,8 @@ EOF
 			}
 			if (!utils::IsTransactionValid($sTransactionId))
 			{
+				$sUser = UserRights::GetUser();
+				IssueLog::Error("UI.php '$operation' : invalid transaction_id ! data: user='$sUser', class='$sClass'");
 				$sMessage = Dict::S('UI:Error:ObjectAlreadyUpdated');
 				$sSeverity = 'info';
 			}