composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-13 07:24:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

✅ Cosmetics on the test framework

Browse Source
This commit is contained in:
Romain Quetiez
2024-07-04 09:38:35 +02:00
parent 989ba7bbe7
commit c3547f29d0
2 changed files with 10 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
tests/php-unit-tests/src/BaseTestCase/ItopDataTestCase.php
View File

@@ -127,7 +127,10 @@ abstract class ItopDataTestCase extends ItopTestCase
}
if (static::CREATE_TEST_ORG)
{
$this->GivenTestOrganization();
// Create a specific organization for the tests
$this->iTestOrgId = $this->GivenObjectInDB('Organization', [
'name' => 'UnitTestOrganization',
]);
}
$oConfig = MetaModel::GetConfig();
@@ -1175,29 +1178,6 @@ abstract class ItopDataTestCase extends ItopTestCase
return $iKey;
}
/**
* Create an Organization in database
*
* @param string $sName
*
* @throws Exception
*/
protected function GivenOrganization($sName): string
{
$sId = $this->GivenObjectInDB('Organization', [
'name' => $sName,
]);
$this->debug("Created Organization $sName");
return $sId;
}
protected function GivenTestOrganization(): void
{
// Create a specific organization for the tests
$this->iTestOrgId = $this->GivenOrganization('UnitTestOrganization');
}
/**
* Create a Farm in database
*

8
tests/php-unit-tests/unitary-tests/tests/php-unit-tests/GivenObjectInDBTest.php
View File

@@ -46,17 +46,21 @@ class GivenObjectInDBTest extends ItopDataTestCase
'first_name' => 'John',
]);
$iRole = $this->GivenObjectInDB('ContactType', [
'name' => 'The Boss',
]);
$iTeam = $this->GivenObjectInDB('Team', [
'name' => 'The A Team',
'persons_list' => [
"person_id:$iPerson;role_id:1"
"person_id:$iPerson;role_id:$iRole"
],
]);
$oSet = new \DBObjectSet(\DBObjectSearch::FromOQL("SELECT lnkPersonToTeam AS lnk WHERE lnk.team_id = $iTeam AND lnk.person_id = $iPerson"));
$this->assertEquals(1, $oSet->Count(), "The link between the team and the person should be there");
$oLnk = $oSet->Fetch();
$this->assertEquals(1, $oLnk->Get('role_id'), "The role should be correctly set");
$this->assertEquals($iRole, $oLnk->Get('role_id'), "The role should be correctly set");
}
public function testItShouldFailExplicitlyWhenAnAttributeCodeIsUnknown()