composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-25 11:38:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°6274 DeprecatedCallsLogTest : replace expectException deprecated calls

Browse Source 
Message was : Support for using expectException() with PHPUnit\Framework\Error\Warning is deprecated and will be removed in PHPUnit 10. Use expectWarning() instead.
This commit is contained in:
Pierre Goiffon
2023-05-05 10:16:56 +02:00
parent 959ac7e3be
commit b9230ad402
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/php-unit-tests/unitary-tests/core/Log/DeprecatedCallsLogTest.php
View File

@@ -9,8 +9,6 @@ namespace Combodo\iTop\Test\UnitTest\Core\Log;
use Combodo\iTop\Test\UnitTest\ItopTestCase;
use DeprecatedCallsLog;
use PHPUnit\Framework\Error\Notice;
use PHPUnit\Framework\Error\Warning;
class DeprecatedCallsLogTest extends ItopTestCase {
/**
@@ -19,15 +17,15 @@ class DeprecatedCallsLogTest extends ItopTestCase {
* @link https://www.php.net/manual/en/migration80.incompatible.php check "A number of notices have been converted into warnings:"
*/
private function SetUndefinedOffsetExceptionToExpect(): void {
if (version_compare(phpversion(), '8.0', '>=')) {
$sUndefinedOffsetExceptionClass = Warning::class;
/** @noinspection ConstantCanBeUsedInspection Preferring the function call as it is easier to read and won't cost that much in this PHPUnit context */
if (version_compare(PHP_VERSION, '8.0', '>=')) {
$this->expectWarning();
$sUndefinedOffsetExceptionMessage = 'Undefined array key "tutu"';
}
else {
$sUndefinedOffsetExceptionClass = Notice::class;
$this->expectNotice();
$sUndefinedOffsetExceptionMessage = 'Undefined index: tutu';
}
$this->expectException($sUndefinedOffsetExceptionClass);
$this->expectExceptionMessage($sUndefinedOffsetExceptionMessage);
}