From b91183e9ec31debcb00bb0110c962ab6611d5236 Mon Sep 17 00:00:00 2001 From: Stephen Abello Date: Wed, 13 Nov 2019 11:18:00 +0100 Subject: [PATCH] =?UTF-8?q?N=C2=B01986=20Portal:=20Fix=20read-only=20forms?= =?UTF-8?q?=20from=20da5ccaa=20to=20work=20with=20auto-generated=20ones?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../portal/src/Form/ObjectFormManager.php | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/datamodels/2.x/itop-portal-base/portal/src/Form/ObjectFormManager.php b/datamodels/2.x/itop-portal-base/portal/src/Form/ObjectFormManager.php index 811c53f83..892964581 100644 --- a/datamodels/2.x/itop-portal-base/portal/src/Form/ObjectFormManager.php +++ b/datamodels/2.x/itop-portal-base/portal/src/Form/ObjectFormManager.php @@ -485,12 +485,6 @@ class ObjectFormManager extends FormManager } continue; } - - // If a form can't be submitted to update an object, we have no reason to allow fields to be editable - if (!$this->GetIsSubmittable()) - { - $sFieldFlags .= ' read_only'; - } // Otherwise we proceed as usual foreach (explode(' ', $sFieldFlags) as $sFieldFlag) @@ -681,7 +675,8 @@ class ObjectFormManager extends FormManager // Failsafe for AttributeType that would not have MakeFormField and therefore could not be used in a form if ($oField !== null) { - if ($this->sMode !== static::ENUM_MODE_VIEW) + // If a form is in edit mode and can't be submitted to update an object (only transitions available), we have no reason to allow fields to be editable + if ($this->sMode !== static::ENUM_MODE_VIEW && $this->GetIsSubmittable()) { // Field dependencies $aFieldDependencies = $oAttDef->GetPrerequisiteAttributes();