Add visibility to class constants (PHP >= 7.1)

This commit is contained in:
Molkobain
2020-08-26 19:02:53 +02:00
parent 8bdaec0129
commit b5c97e35bf
32 changed files with 154 additions and 151 deletions

View File

@@ -37,16 +37,16 @@ use UserRights;
class ActivityEntry extends UIBlock
{
// Overloaded constants
const BLOCK_CODE = 'ibo-activity-entry';
const HTML_TEMPLATE_REL_PATH = 'layouts/activity-panel/activity-entry/layout';
public const BLOCK_CODE = 'ibo-activity-entry';
public const HTML_TEMPLATE_REL_PATH = 'layouts/activity-panel/activity-entry/layout';
// Specific constants
/** @var string DEFAULT_ORIGIN */
const DEFAULT_ORIGIN = 'unknown';
public const DEFAULT_ORIGIN = 'unknown';
/** @var string DEFAULT_TYPE */
const DEFAULT_TYPE = 'generic';
public const DEFAULT_TYPE = 'generic';
/** @var string DEFAULT_DECORATION_CLASSES */
const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-mortar-pestle';
public const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-mortar-pestle';
/** @var string $sType Type of entry, used for filtering (eg. caselog, edits, transition, ...) */
protected $sType;

View File

@@ -28,5 +28,5 @@ namespace Combodo\iTop\Application\UI\Layout\ActivityPanel\ActivityEntry\CMDBCha
*/
class CMDBChangeOpAttachmentAddedFactory extends CMDBChangeOpFactory
{
const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-paperclip';
public const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-paperclip';
}

View File

@@ -30,5 +30,5 @@ use iCMDBChangeOp;
*/
class CMDBChangeOpAttachmentRemovedFactory extends CMDBChangeOpFactory
{
const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-unlink';
public const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-unlink';
}

View File

@@ -30,7 +30,8 @@ use iCMDBChangeOp;
*/
class CMDBChangeOpCreateFactory extends CMDBChangeOpFactory
{
const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-unlink';
public const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-unlink';
/**
* @inheritDoc
*/

View File

@@ -30,7 +30,8 @@ use iCMDBChangeOp;
*/
class CMDBChangeOpDeleteFactory extends CMDBChangeOpFactory
{
const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-unlink';
public const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-unlink';
/**
* @inheritDoc
*/

View File

@@ -37,9 +37,9 @@ use iCMDBChangeOp;
class CMDBChangeOpFactory
{
/** @var string DEFAULT_TYPE Used to overload the type from the ActivityEntry */
const DEFAULT_TYPE = EditsEntry::DEFAULT_TYPE;
public const DEFAULT_TYPE = EditsEntry::DEFAULT_TYPE;
/** @var string DEFAULT_DECORATION_CLASSES Used to overload the decoration classes from the ActivityEntry */
const DEFAULT_DECORATION_CLASSES = ActivityEntry::DEFAULT_DECORATION_CLASSES;
public const DEFAULT_DECORATION_CLASSES = ActivityEntry::DEFAULT_DECORATION_CLASSES;
/**
* Make an ActivityEntry from the iCMDBChangeOp $oChangeOp

View File

@@ -33,11 +33,11 @@ use DateTime;
class CaseLogEntry extends ActivityEntry
{
// Overloaded constants
const BLOCK_CODE = 'ibo-caselog-entry';
const HTML_TEMPLATE_REL_PATH = 'layouts/activity-panel/activity-entry/caselog-entry';
public const BLOCK_CODE = 'ibo-caselog-entry';
public const HTML_TEMPLATE_REL_PATH = 'layouts/activity-panel/activity-entry/caselog-entry';
const DEFAULT_TYPE = 'caselog';
const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-quote-left';
public const DEFAULT_TYPE = 'caselog';
public const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-quote-left';
// Specific constants
public const DEFAULT_CASELOG_RANK = 0;

View File

@@ -36,11 +36,11 @@ use MetaModel;
class EditsEntry extends ActivityEntry
{
// Overloaded constants
const BLOCK_CODE = 'ibo-edits-entry';
const HTML_TEMPLATE_REL_PATH = 'layouts/activity-panel/activity-entry/edits-entry';
public const BLOCK_CODE = 'ibo-edits-entry';
public const HTML_TEMPLATE_REL_PATH = 'layouts/activity-panel/activity-entry/edits-entry';
const DEFAULT_TYPE = 'edits';
const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-pen';
public const DEFAULT_TYPE = 'edits';
public const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-pen';
/** @var string $sObjectClass */
protected $sObjectClass;

View File

@@ -33,11 +33,11 @@ use DateTime;
class TransitionEntry extends ActivityEntry
{
// Overloaded constants
const BLOCK_CODE = 'ibo-transition-entry';
const HTML_TEMPLATE_REL_PATH = 'layouts/activity-panel/activity-entry/transition-entry';
public const BLOCK_CODE = 'ibo-transition-entry';
public const HTML_TEMPLATE_REL_PATH = 'layouts/activity-panel/activity-entry/transition-entry';
const DEFAULT_TYPE = 'transition';
const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-map-signs';
public const DEFAULT_TYPE = 'transition';
public const DEFAULT_DECORATION_CLASSES = 'fas fa-fw fa-map-signs';
/** @var string $sOriginStateCode Code of the state before the transition */
protected $sOriginStateCode;