N°4714 Rename \utils::GetItopVersionWikiSyntax to GetCoreVersionWikiSyntax

Will avoid confusion between core or product version !
This commit is contained in:
Pierre Goiffon
2022-02-01 15:40:43 +01:00
parent 17612f88d3
commit b4fc647845
3 changed files with 5 additions and 5 deletions

View File

@@ -2246,11 +2246,11 @@ class utils
} }
/** /**
* @return string eg : '2_7_0' iTop core version is '2.7.1-dev' * @return string eg : '2_7_0' if iTop core version is '2.7.5-2'
* @throws \ApplicationException if constant value is invalid * @throws \ApplicationException if constant value is invalid
* @uses ITOP_CORE_VERSION * @uses ITOP_CORE_VERSION
*/ */
public static function GetItopVersionWikiSyntax() public static function GetCoreVersionWikiSyntax()
{ {
$aExplodedVersion = explode('.', ITOP_CORE_VERSION); $aExplodedVersion = explode('.', ITOP_CORE_VERSION);

View File

@@ -11,7 +11,7 @@ define('APPCONF', APPROOT.'conf/');
* When releasing, both constants should be updated : see `.make/release/update-versions.php` for that ! * When releasing, both constants should be updated : see `.make/release/update-versions.php` for that !
* *
* @since 2.7.7 3.0.1 3.1.0 N°4714 constant creation * @since 2.7.7 3.0.1 3.1.0 N°4714 constant creation
* @used-by utils::GetItopVersionWikiSyntax() * @used-by utils::GetCoreVersionWikiSyntax()
* @used-by iTopModulesPhpVersionIntegrationTest * @used-by iTopModulesPhpVersionIntegrationTest
*/ */
define('ITOP_CORE_VERSION', '2.7.7'); define('ITOP_CORE_VERSION', '2.7.7');

View File

@@ -918,7 +918,7 @@ class SetupUtils
$oPage, $bIsItopInstall, $sDBServer, $sDBUser, $sDBPwd, $sDBName, $sDBPrefix, $bTlsEnabled, $sTlsCA, $oPage, $bIsItopInstall, $sDBServer, $sDBUser, $sDBPwd, $sDBName, $sDBPrefix, $bTlsEnabled, $sTlsCA,
$sNewDBName = '' $sNewDBName = ''
) { ) {
$sWikiVersion = utils::GetItopVersionWikiSyntax(); //eg : '2_7_0'; $sWikiVersion = utils::GetCoreVersionWikiSyntax(); //eg : '2_7_0';
$sMysqlTlsWikiPageUrl = 'https://www.itophub.io/wiki/page?id='.$sWikiVersion.':install:php_and_mysql_tls'; $sMysqlTlsWikiPageUrl = 'https://www.itophub.io/wiki/page?id='.$sWikiVersion.':install:php_and_mysql_tls';
$oPage->add('<tr><td colspan="2">'); $oPage->add('<tr><td colspan="2">');
@@ -1194,7 +1194,7 @@ EOF
{ {
$aResult['checks'][] = new CheckResult(CheckResult::INFO, "MySQL server's max_allowed_packet ($sMaxAllowedPacketFriendly) is big enough compared to upload_max_filesize ($sMaxUploadSizeFriendly)."); $aResult['checks'][] = new CheckResult(CheckResult::INFO, "MySQL server's max_allowed_packet ($sMaxAllowedPacketFriendly) is big enough compared to upload_max_filesize ($sMaxUploadSizeFriendly).");
} else if ($iMaxAllowedPacket < $iMaxUploadSize) { } else if ($iMaxAllowedPacket < $iMaxUploadSize) {
$sWikiVersion = utils::GetItopVersionWikiSyntax(); //eg : '2_7_0'; $sWikiVersion = utils::GetCoreVersionWikiSyntax(); //eg : '2_7_0';
$sAttachmentsVarsWikiPageUrl = 'https://www.itophub.io/wiki/page?id='.$sWikiVersion $sAttachmentsVarsWikiPageUrl = 'https://www.itophub.io/wiki/page?id='.$sWikiVersion
.':install:php_and_mysql_configuration#attachments_upload'; .':install:php_and_mysql_configuration#attachments_upload';