composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-03-04 08:34:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

N°3060 - filter modules autoinstalled in checklist test

Browse Source
This commit is contained in:
odain
2020-08-06 11:00:53 +02:00
parent b9145ca996
commit b0609e86d1
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/releaseChecklist/iTopModuleXmlInstallationChecklistTest.php
View File

@@ -49,6 +49,10 @@ class iTopModuleXmlInstallationChecklistTest extends ItopTestCase
public function testAllModuleAreIncludedInInstallationXml()
{
$sInstallationXmlPath = APPROOT.'datamodels/2.x/installation.xml';
if (!is_file($sInstallationXmlPath))
{
$sInstallationXmlPath = APPROOT.'datamodels/1.x/installation.xml';
}
$this->assertTrue(is_file($sInstallationXmlPath), "$sInstallationXmlPath does not exist");
$sInstallationXmlContent = file_get_contents($sInstallationXmlPath);
@@ -67,7 +71,7 @@ class iTopModuleXmlInstallationChecklistTest extends ItopTestCase
$aModulesFromDatamodels = $this->GetModulesFromDatamodels(APPROOT.'/datamodels');
$this->assertArraySubset($aModulesFromDatamodels, $aDeclaredModules, false, "$sInstallationXmlPath does not refer to all provided modules. Refered modules:\n " . var_export($aDeclaredModules, true));
$this->assertArraySubset($aDeclaredModules, $aModulesFromDatamodels, false, "Not all modules are contained in $sInstallationXmlPath. Refered modules:\n " . var_export($aModulesFromDatamodels, true));²²
$this->assertArraySubset($aDeclaredModules, $aModulesFromDatamodels, false, "Not all modules are contained in $sInstallationXmlPath. Refered modules:\n " . var_export($aModulesFromDatamodels, true));
}
public function GetModulesFromDatamodels($sFolder)
@@ -84,10 +88,16 @@ class iTopModuleXmlInstallationChecklistTest extends ItopTestCase
else if (preg_match("/module\..*\.php/", basename($sPath)))
{
$sModulePhpContent = file_get_contents($sPath);
if (strpos($sModulePhpContent, "SetupWebPage::AddModule(")!==false
&& strpos($sModulePhpContent, "'mandatory' => true,")===false
&& strpos($sModulePhpContent, "'visible' => false,")===false)
if (strpos($sModulePhpContent, "SetupWebPage::AddModule")!==false
&& strpos($sModulePhpContent, "'mandatory' => true")===false)
{
//filter modules autoselected due to below condition
if (strpos($sModulePhpContent, "'mandatory' => false")!==false
&& strpos($sModulePhpContent, "'visible' => false")!==false)
{
continue;
}
$sModule = basename(dirname($sPath));
$aModules[$sModule] = $sModule;
}