From ada7f307937581660edb1daff829f1f5e46b7f52 Mon Sep 17 00:00:00 2001 From: acognet Date: Tue, 27 Oct 2020 09:59:05 +0100 Subject: [PATCH] =?UTF-8?q?N=C2=B03139=20-=20import=20csv=20:=20hyperlink?= =?UTF-8?q?=20not=20clickable=20-=20replace=20htmlentities=20with=20utils:?= =?UTF-8?q?:HtmlEntities()=20to=20ensure=20that=20the=20same=20options=20a?= =?UTF-8?q?re=20used=20application=20wide.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- core/bulkchange.class.inc.php | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/core/bulkchange.class.inc.php b/core/bulkchange.class.inc.php index 7247067e5..976d894d5 100644 --- a/core/bulkchange.class.inc.php +++ b/core/bulkchange.class.inc.php @@ -309,7 +309,7 @@ class BulkChange $value = $oForeignAtt->MakeValueFromString($aRowData[$iCol], $this->m_bLocalizedValues); } $oReconFilter->AddCondition($sForeignAttCode, $value, '='); - $aResults[$iCol] = new CellStatus_Void(htmlentities($aRowData[$iCol])); + $aResults[$iCol] = new CellStatus_Void(utils::HtmlEntities($aRowData[$iCol])); } $oExtObjects = new CMDBObjectSet($oReconFilter); @@ -396,7 +396,7 @@ class BulkChange } $aCacheKeys[] = $value; $oReconFilter->AddCondition($sForeignAttCode, $value, '='); - $aResults[$iCol] = new CellStatus_Void(htmlentities($aRowData[$iCol])); + $aResults[$iCol] = new CellStatus_Void(utils::HtmlEntities($aRowData[$iCol])); } $sCacheKey = implode('_|_', $aCacheKeys); // Unique key for this query... $iForeignKey = null; @@ -466,7 +466,7 @@ class BulkChange foreach ($aKeyConfig as $sForeignAttCode => $iCol) { // Report the change on reconciliation values as well - $aResults[$iCol] = new CellStatus_Modify(htmlentities($aRowData[$iCol])); + $aResults[$iCol] = new CellStatus_Modify(utils::HtmlEntities($aRowData[$iCol])); } } } @@ -539,7 +539,7 @@ class BulkChange { if ($sAttCode == 'id') { - $aResults[$iCol]= new CellStatus_Void(htmlentities($aRowData[$iCol])); + $aResults[$iCol]= new CellStatus_Void(utils::HtmlEntities($aRowData[$iCol])); } else { @@ -555,7 +555,7 @@ class BulkChange } if (isset($aErrors[$sAttCode])) { - $aResults[$iCol]= new CellStatus_Issue(htmlentities($aRowData[$iCol]), $sOrigValue, $aErrors[$sAttCode]); + $aResults[$iCol]= new CellStatus_Issue(utils::HtmlEntities($aRowData[$iCol]), $sOrigValue, $aErrors[$sAttCode]); } elseif (array_key_exists($sAttCode, $aChangedFields)) { @@ -578,7 +578,7 @@ class BulkChange } else { - $aResults[$iCol]= new CellStatus_Void(htmlentities($aRowData[$iCol])); + $aResults[$iCol]= new CellStatus_Void(utils::HtmlEntities($aRowData[$iCol])); } } } @@ -925,7 +925,7 @@ class BulkChange { // Leave the cell unchanged $aResult[$iRow]["__STATUS__"]= new RowStatus_Issue(Dict::S('UI:CSVReport-Row-Issue-DateFormat')); - $aResult[$iRow][$sAttCode] = new CellStatus_Issue(null, htmlentities($this->m_aData[$iRow][$iCol]), Dict::S('UI:CSVReport-Row-Issue-DateFormat')); + $aResult[$iRow][$sAttCode] = new CellStatus_Issue(null, utils::HtmlEntities($this->m_aData[$iRow][$iCol]), Dict::S('UI:CSVReport-Row-Issue-DateFormat')); } } } @@ -1083,7 +1083,7 @@ class BulkChange { if (!array_key_exists($iCol, $aResult[$iRow])) { - $aResult[$iRow][$iCol] = new CellStatus_Void(htmlentities($aRowData[$iCol])); + $aResult[$iRow][$iCol] = new CellStatus_Void(utils::HtmlEntities($aRowData[$iCol])); } } foreach($this->m_aExtKeys as $sAttCode => $aForeignAtts) @@ -1097,7 +1097,7 @@ class BulkChange if (!array_key_exists($iCol, $aResult[$iRow])) { // The foreign attribute is one of our reconciliation key - $aResult[$iRow][$iCol] = new CellStatus_Void(htmlentities($aRowData[$iCol])); + $aResult[$iRow][$iCol] = new CellStatus_Void(utils::HtmlEntities($aRowData[$iCol])); } } }