N°2585 - Fix alias problem in portal scopes

The re-aliasing map structure now allows multiple mapping for the same alias (used for the translations of UNIONS)

test/core/DBSearchUpdateRealiasingMapTest.php

@@ -0,0 +1,88 @@
+<?php
+
+namespace Combodo\iTop\Test\UnitTest\Core;
+
+use Combodo\iTop\Test\UnitTest\ItopDataTestCase;
+use DBObjectSearch;
+
+
+/**
+ * Class DBSearchUpdateRealiasingMapTest
+ *
+ * @package Combodo\iTop\Test\UnitTest\Core
+ *
+ * @runTestsInSeparateProcesses
+ * @preserveGlobalState disabled
+ * @backupGlobals disabled
+ */
+class DBSearchUpdateRealiasingMapTest extends ItopDataTestCase
+{
+	const USE_TRANSACTION = false;
+
+	protected function setUp()
+	{
+		parent::setUp();
+		require_once(APPROOT.'application/startup.inc.php');
+	}
+
+	/**
+	 * @dataProvider UpdateRealiasingMapProvider
+	 * @param $aRealiasingMap
+	 * @param $aAliasTranslation
+	 * @param $aExpectedRealiasingMap
+	 */
+	public function testUpdateRealiasingMap($aRealiasingMap, $aAliasTranslation, $aExpectedRealiasingMap)
+	{
+		$this->UpdateRealiasingMap($aRealiasingMap, $aAliasTranslation);
+		$this->assertEquals($aExpectedRealiasingMap, $aRealiasingMap);
+	}
+
+	public function UpdateRealiasingMapProvider()
+	{
+		return [
+			'empty' => [
+				'OriginalMap' => null,
+				'AliasTranslation' => [],
+				'ExpectedMap' => null
+			],
+			'Add 1 alias' => [
+				'OriginalMap' => [],
+				'AliasTranslation' => ['a' => ['*' => 'b']],
+				'ExpectedMap' => ['a' => ['b']]
+			],
+			'Add 2 aliases' => [
+				'OriginalMap' => [],
+				'AliasTranslation' => ['a' => ['*' => 'b'], 'c' => ['*' => 'd']],
+				'ExpectedMap' => ['a' => ['b'], 'c' => ['d']]
+			],
+			'Append 1 alias' => [
+				'OriginalMap' => ['a' => ['b']],
+				'AliasTranslation' => ['c' => ['*' => 'd']],
+				'ExpectedMap' => ['a' => ['b'], 'c' => ['d']]
+			],
+			'Merge 1 alias' => [
+				'OriginalMap' => ['a' => ['b']],
+				'AliasTranslation' => ['a' => ['*' => 'd']],
+				'ExpectedMap' => ['a' => ['b', 'd']]
+			],
+			'Merge same alias' => [
+				'OriginalMap' => ['a' => ['b']],
+				'AliasTranslation' => ['a' => ['*' => 'b']],
+				'ExpectedMap' => ['a' => ['b']]
+			],
+			'Transitivity a->b + b->f = a->f' => [
+				'OriginalMap' => ['a' => ['b', 'd'], 'c' => ['e']],
+				'AliasTranslation' => ['b' => ['*' => 'f']],
+				'ExpectedMap' => ['a' => ['f', 'd'], 'c' => ['e']]
+			],
+		];
+	}
+
+	private function UpdateRealiasingMap(&$aRealiasingMap, $aAliasTranslation)
+	{
+		$class = new \ReflectionClass(DBObjectSearch::class);
+		$method = $class->getMethod('UpdateRealiasingMap');
+		$method->setAccessible(true);
+		$method->invokeArgs(new DBObjectSearch('Organization'), [&$aRealiasingMap, $aAliasTranslation]);
+	}
+}