From a3dda04961e4aa005af690b50d5cce49a477e282 Mon Sep 17 00:00:00 2001 From: Guillaume Lajarige Date: Tue, 18 Apr 2017 13:58:51 +0000 Subject: [PATCH] (Retrofit from trunk) Portal: Refactor a security check to remove unnecessary security messages in error.log SVN:2.3[4685] --- .../portal/src/controllers/managebrickcontroller.class.inc.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datamodels/2.x/itop-portal-base/portal/src/controllers/managebrickcontroller.class.inc.php b/datamodels/2.x/itop-portal-base/portal/src/controllers/managebrickcontroller.class.inc.php index f180265f7..01494efbb 100644 --- a/datamodels/2.x/itop-portal-base/portal/src/controllers/managebrickcontroller.class.inc.php +++ b/datamodels/2.x/itop-portal-base/portal/src/controllers/managebrickcontroller.class.inc.php @@ -368,7 +368,7 @@ class ManageBrickController extends BrickController if ($sItemAttr === $sMainActionAttrCode) { // Checking if we can edit the object - if (SecurityHelper::IsActionAllowed($oApp, UR_ACTION_MODIFY, $sCurrentClass, $oCurrentRow->GetKey()) && ($oBrick->GetOpeningMode() === ManageBrick::ENUM_ACTION_EDIT)) + if (($oBrick->GetOpeningMode() === ManageBrick::ENUM_ACTION_EDIT) && SecurityHelper::IsActionAllowed($oApp, UR_ACTION_MODIFY, $sCurrentClass, $oCurrentRow->GetKey())) { $sActionType = ManageBrick::ENUM_ACTION_EDIT; }