composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-23 18:48:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°5784 - PHP 8.0: Fix mandatory attribute not visible in transition form due to bad emptiness test (#379)

Browse Source 
* N°5784 - PHP 8.0: Fix mandatory attribute not visible in transition form due to bad emptiness test

* N°5784 - Rework AttributeDefinition::HasAValue() implementation after code review

* N°5784 - Add unit test
This commit is contained in:
Molkobain
2023-03-07 10:16:14 +01:00
committed by GitHub
parent 03fb78c38c
commit a34274b883
4 changed files with 338 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

144
tests/php-unit-tests/unitary-tests/core/AttributeDefTest.inc.php
View File

@@ -29,4 +29,148 @@ class AttributeDefTest extends ItopDataTestCase {
$this->assertEquals(["status" => "ENUM('active','inactive') CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci"],
$aImportColumns);
}
/**
* @dataProvider HasAValueProvider
* @covers AttributeDefinition::HasAValue
*
* @param $sObjectClass
* @param $sAttCode
* @param $sUpdateCode
* @param $bHasAValueInitially
* @param $bHasAValueOnceSet
*
* @return void
* @throws \ArchivedObjectException
* @throws \CoreException
*/
public function testHasAValue($sObjectClass, $sAttCode, $sUpdateCode, $bHasAValueInitially, $bHasAValueOnceSet)
{
$oObject = MetaModel::NewObject($sObjectClass);
// Test attribute without a value yet
$this->assertEquals($bHasAValueInitially, $oObject->HasAValue($sAttCode));
eval($sUpdateCode);
// Test attribute once a value has been set
$this->assertEquals($bHasAValueOnceSet, $oObject->HasAValue($sAttCode));
}
public function HasAValueProvider(): array
{
// Note: This is test is not great as we are datamodel dependent and don't have a class with all the attribute types
return [
'AttributeDashboard' => [
'Organization',
'overview',
'',
false,
false,
],
'AttributeLinkedSet' => [
'UserRequest',
'workorders_list',
<<<PHP
/** @var \ormLinkSet \$ormLinkset */
\$ormLinkset = \$oObject->Get('workorders_list');
\$ormLinkset->AddItem(MetaModel::NewObject('WorkOrder', []));
\$oObject->Set('workorders_list', \$ormLinkset);
PHP,
false,
true,
],
'AttributeLinkedSetIndirect' => [
'UserRequest',
'contacts_list',
<<<PHP
/** @var \ormLinkSet \$ormLinkset */
\$ormLinkset = \$oObject->Get('contacts_list');
\$ormLinkset->AddItem(MetaModel::NewObject('Person', []));
\$oObject->Set('contacts_list', \$ormLinkset);
PHP,
false,
true,
],
'AttributeInteger' => [
'SLT',
'value',
<<<PHP
\$oObject->Set('value', 100);
PHP,
false,
true,
],
'AttributeDecimal' => [
'PhysicalInterface',
'speed',
<<<PHP
\$oObject->Set('speed', 1024.5);
PHP,
false,
true,
],
'AttributeString' => [
'UserRequest',
'title',
<<<PHP
\$oObject->Set('title', 'Some title');
PHP,
false,
true,
],
'AttributeObjectKey' => [
'Attachment',
'item_id',
<<<PHP
\$oObject->Set('item_id', 12);
PHP,
false,
true,
],
'AttributeExternalKey' => [
'UserRequest',
'org_id',
<<<PHP
\$oObject->Set('org_id', 3);
PHP,
false,
true,
],
'AttributeBlob' => [
'DocumentFile',
'file',
<<<PHP
\$oObject->Set('file', new ormDocument('something', 'text/plain', 'something.txt'));
PHP,
false,
true,
],
'AttributeStopWatch' => [
'UserRequest',
'tto',
'',
true,
true,
],
'AttributeSubItem' => [
'UserRequest',
'tto_escalation_deadline',
'',
true,
true,
],
'AttributeOneWayPassword' => [
'UserLocal',
'password',
<<<PHP
$/** @var \ormPassword \$ormPassword */
\$ormPassword = new ormPassword('somehash', 'somesalt');
\$oObject->Set('password', \$ormPassword);
PHP,
false,
true,
],
];
}
}