From a2bddea1e2630bf6644b370aa8a4a4ee2f6a622b Mon Sep 17 00:00:00 2001
From: Molkobain <lajarige.guillaume@free.fr>
Date: Thu, 4 Jul 2024 23:33:38 +0200
Subject: [PATCH] =?UTF-8?q?N=C2=B07565=20-=20Forbid=20disabling=20internal?=
 =?UTF-8?q?=20newsroom=20provider?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 pages/preferences.php | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/pages/preferences.php b/pages/preferences.php
index bbc998419..c25db92ed 100644
--- a/pages/preferences.php
+++ b/pages/preferences.php
@@ -4,6 +4,7 @@
  * @license     http://opensource.org/licenses/AGPL-3.0
  */
 
+use Combodo\iTop\Application\Newsroom\iTopNewsroomProvider;
 use Combodo\iTop\Application\UI\Base\Component\Button\ButtonUIBlockFactory;
 use Combodo\iTop\Application\UI\Base\Component\FieldSet\FieldSetUIBlockFactory;
 use Combodo\iTop\Application\UI\Base\Component\Form\Form;
@@ -298,8 +299,12 @@ JS
 					}
 					$sPreferencesLink = ' - <a class=".newsroom-configuration-link" href="'.$sUrl.'"'.$sTarget.'>'.Dict::S('UI:Newsroom:ConfigurationLink').'</a>';
 				}
-				$sChecked = appUserPreferences::GetPref('newsroom_provider_'.$sProviderClass, true) ? ' checked="" ' : '';
-				$sNewsroomHtml .= '<div><input type="checkbox" id="newsroom_provider_'.$sProviderClass.'" value="on"'.$sChecked.'name="newsroom_provider_'.$sProviderClass.'"><label for="newsroom_provider_'.$sProviderClass.'">'.Dict::Format('UI:Newsroom:DisplayMessagesFor_Provider',
+
+				$sCheckedForHtml = appUserPreferences::GetPref('newsroom_provider_'.$sProviderClass, true) ? 'checked' : '';
+				// Forbid disabling internal newsroom provider
+				$sDisabledForHtml = $sProviderClass === iTopNewsroomProvider::class ? 'disabled' : '';
+
+				$sNewsroomHtml .= '<div><input type="checkbox" id="newsroom_provider_'.$sProviderClass.'" value="on" '.$sCheckedForHtml.' '.$sDisabledForHtml.' name="newsroom_provider_'.$sProviderClass.'"><label for="newsroom_provider_'.$sProviderClass.'">'.Dict::Format('UI:Newsroom:DisplayMessagesFor_Provider',
 						$oProvider->GetLabel()).'</label> '.$sPreferencesLink.'</div>';
 			}
 		}
@@ -872,6 +877,11 @@ try {
 				$bProvidersModified = false;
 				foreach ($aProviders as $cProvider)
 				{
+					// Forbid disabling internal newsroom provider
+					if ($cProvider === iTopNewsroomProvider::class) {
+						continue;
+					}
+
 					$oProvider = new $cProvider();
 					if ($oProvider->IsApplicable($oUser))
 					{