composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-24 02:58:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°4342 - Improve generic bulk deletion function with memory limit handling - add tests

Browse Source
This commit is contained in:
Anne-Cath
2024-06-24 14:55:17 +02:00
parent c1ce4f9a9f
commit a160f2e212
1 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
tests/php-unit-tests/unitary-tests/core/MetaModelTest.php
View File

@@ -462,12 +462,13 @@ class MetaModelTest extends ItopDataTestCase
* @return void * @return void
* @throws CoreException * @throws CoreException
* @throws \OQLException * @throws \OQLException
* @dataProvider PurgeDataProvider
*
*/ */
public function testPurgeData(){ public function testPurgeData( $iMaxChunkSize, $iNbQueriesExpected){
// Set max_chunk_size to 2 (default 1000) to test chunk deletion with only 10 items // Set max_chunk_size to $iMaxChunkSize (default 1000) to test chunk deletion with only 10 items
$oConfig = MetaModel::GetConfig(); $oConfig = MetaModel::GetConfig();
$oConfig->Set('purge_data.max_chunk_size', 2); $oConfig->Set('purge_data.max_chunk_size', $iMaxChunkSize);
MetaModel::SetConfig($oConfig);
$aPkPerson = []; $aPkPerson = [];
for ($i=0; $i < 10; $i++) { for ($i=0; $i < 10; $i++) {
@@ -476,12 +477,23 @@ class MetaModelTest extends ItopDataTestCase
$aPkPerson[] = $oPerson->GetKey(); $aPkPerson[] = $oPerson->GetKey();
} }
$sDeleteOQL = 'SELECT '.$sClass.' WHERE id IN ('.implode(',', $aPkPerson).')'; $oFilter = DBObjectSearch::FromOQL('SELECT '.$sClass.' WHERE id IN ('.implode(',', $aPkPerson).')');
$oFilter = DBObjectSearch::FromOQL($sDeleteOQL); $iNbDelete = 0;
$this->assertDBQueryCount($iNbQueriesExpected, function() use ($oFilter, &$iNbDelete) {
$iNbDelete = MetaModel::PurgeData($oFilter);
} );
$iNbDelete = MetaModel::PurgeData($oFilter);
$this->assertEquals($iNbDelete, 10, 'MetaModel::PurgeData must delete 10 objects per batch of 2 items'); $this->assertEquals($iNbDelete, 10, 'MetaModel::PurgeData must delete 10 objects per batch of 2 items');
} }
public function PurgeDataProvider(){
return [
'Purge 10 items with a max_chunk_size of 2 should be perfomed in 5 steps + an additional query to verify that the job is complete' => [2, 16],
'Purge 10 items with a max_chunk_size of 3 should be perfomed in 4 steps' => [3, 12],
'Purge 10 items with a max_chunk_size of 1000 (default value) should be perfomed in 1 step' => [1000, 3],
];
}
} }
abstract class Wizzard abstract class Wizzard