From 94c4f8c929dac5ceed7ae956182eb2c85e00cee2 Mon Sep 17 00:00:00 2001
From: Pierre Goiffon <pierre.goiffon@combodo.com>
Date: Thu, 23 Feb 2023 12:04:56 +0100
Subject: [PATCH] =?UTF-8?q?N=C2=B06016=20MissingDependencyException=20:=20?=
 =?UTF-8?q?better=20log=20message=20(#355)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The error displayed on screen was already improved (see #280)
This commit improves the log message we can have for example by running unattended install.
---
 setup/modulediscovery.class.inc.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/setup/modulediscovery.class.inc.php b/setup/modulediscovery.class.inc.php
index dc22780e7..4dd2e281a 100644
--- a/setup/modulediscovery.class.inc.php
+++ b/setup/modulediscovery.class.inc.php
@@ -31,7 +31,7 @@ class MissingDependencyException extends CoreException
 
 	/**
 	 * @return string HTML to print to the user the modules impacted
-	 * @since 2.7.7 3.0.2 3.1.0 PR #280
+	 * @since 2.7.7 3.0.2 3.1.0 N°5090 PR #280
 	 */
 	public function getHtmlDesc($sHighlightHtmlBegin = null, $sHighlightHtmlEnd = null)
 	{
@@ -254,10 +254,10 @@ class ModuleDiscovery
 			foreach($aDependencies as $sId => $aDeps)
 			{
 				$aModule = $aModules[$sId];
-				$aModuleDeps[] = "{$aModule['label']} (id: $sId) depends on ".implode(' + ', $aDeps);
+				$aModuleDeps[] = "{$aModule['label']} (id: $sId) depends on: ".implode(' + ', $aDeps);
 				$aModulesInfo[$sId] = array('module' => $aModule, 'dependencies' => $aDeps);
 			}
-			$sMessage = "The following modules have unmet dependencies: ".implode(', ', $aModuleDeps);
+			$sMessage = "The following modules have unmet dependencies:\n".implode(",\n", $aModuleDeps);
 			$oException = new MissingDependencyException($sMessage);
 			$oException->aModulesInfo = $aModulesInfo;
 			throw $oException;