composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-05-21 16:22:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°4124 - Extract computations into variables for easier comprehension

Browse Source
This commit is contained in:
Molkobain
2021-08-03 11:37:01 +02:00
parent c0aa4f2d69
commit 90cb6e1d49
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
js/components/panel.js
View File

@@ -147,8 +147,11 @@ $(function () {
} }
}, },
_onHeaderStopsBeingSticky: function () { _onHeaderStopsBeingSticky: function () {
//test to prevent the screen from flashing (cf bug 4124) const fPanelBottomPosition = this.element.position().top + this.element.find(this.js_selectors.block.panel_header_sticky_sentinel_top).outerHeight();
if ((this.element.position().top+this.element.find(this.js_selectors.block.panel_header_sticky_sentinel_top).outerHeight()) < (this.options.viewport_elem.scrollHeight-this.options.viewport_elem.clientHeight)) { const fViewportVerticalScrollPosition = this.options.viewport_elem.scrollHeight - this.options.viewport_elem.clientHeight;
// Test to prevent the screen from flashing (cf bug 4124)
if (fPanelBottomPosition < fViewportVerticalScrollPosition) {
this.element.find(this.js_selectors.block.panel_header).removeClass(this.css_classes.is_sticking); this.element.find(this.js_selectors.block.panel_header).removeClass(this.css_classes.is_sticking);
if (this._hasTabContainer()) { if (this._hasTabContainer()) {
this._updateTabsListPosition(false /* Need to wait for the header transition to end */); this._updateTabsListPosition(false /* Need to wait for the header transition to end */);