composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-24 02:58:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°7216 import improves error handling missing or null data (#612)

Browse Source 
Co-authored-by: Thomas Casteleyn <thomas.casteleyn@super-visions.com>
This commit is contained in:
Anne-Catherine
2025-01-30 16:14:14 +01:00
committed by GitHub
parent 8a604c643e
commit 8e0e01ad40
6 changed files with 121 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/php-unit-tests/unitary-tests/datamodels/2.x/itop-config/BulkChangeExtKeyTest.php
View File

@@ -183,11 +183,11 @@ class BulkChangeExtKeyTest extends ItopDataTestCase {
null,
null,
null,
null,
'Found 2 matches'
);
}
/**
* @dataProvider ReconciliationKeyProvider
*/
@@ -209,6 +209,7 @@ class BulkChangeExtKeyTest extends ItopDataTestCase {
null,
$bIsRackReconKey,
$aCsvData,
['description'=>3],
$aExtKeys,
$sSearchLinkUrl
);
@@ -224,7 +225,7 @@ class BulkChangeExtKeyTest extends ItopDataTestCase {
}
public function performBulkChangeTest($sExpectedDisplayableValue, $sExpectedDescription, $oOrg, $bIsRackReconKey,
$aAdditionalCsvData=null, $aExtKeys=null, $sSearchLinkUrl=null, $sError="Object not found") {
$aAdditionalCsvData=null, $aAdditionalAttributes=null, $aExtKeys=null, $sSearchLinkUrl=null, $sError="Object not found") {
if ($sSearchLinkUrl===null){
$sSearchLinkUrl = 'UI.php?operation=search&filter='.rawurlencode('%5B%22SELECT+%60Rack%60+FROM+Rack+AS+%60Rack%60+WHERE+%28%60Rack%60.%60name%60+%3D+%3Aname%29%22%2C%7B%22name%22%3A%22UnexistingRack%22%7D%2C%5B%5D%5D');
}
@@ -247,6 +248,9 @@ class BulkChangeExtKeyTest extends ItopDataTestCase {
}
}
$aAttributes = ["name" => 2];
if ($aAdditionalAttributes !== null){
$aAttributes = array_merge($aAttributes, $aAdditionalAttributes);
}
if ($aExtKeys == null){
$aExtKeys = ["org_id" => ["name" => 0], "rack_id" => ["name" => 1]];
}