composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-02-12 23:14:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

N°6562 Replace new DOMText() by \DOMDocument::createTextNode

Browse Source 
Because init using constructor outputs a read only node, see https://www.php.net/manual/en/domelement.construct.php
Thanks @Hipska
See conversation in 734a788
This commit is contained in:
Pierre Goiffon
2023-08-03 09:40:39 +02:00
parent 7aa478d6ff
commit 880a824f2f
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
setup/itopdesignformat.class.inc.php
View File

@@ -895,7 +895,9 @@ class iTopDesignFormat
// N°6562 textContent is readonly, see https://www.php.net/manual/en/class.domnode.php#95545
// $oNode->textContent = $sCode;
// N°6562 to update text node content we must use the node methods !
$oTextContentNode = new DOMText($sCode);
// we are using DOMDocument::createTextNode instead of new DOMText because elements created using the constructor are read only
// see https://www.php.net/manual/en/domelement.construct.php
$oTextContentNode = $this->oDocument->createTextNode($sCode);
$oNode->appendChild($oTextContentNode);
}
}