composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-24 02:58:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

Introduce type hinting in methods prototype (PHP >= 7.1)

Browse Source
This commit is contained in:
Molkobain
2020-08-26 21:21:56 +02:00
parent 77cd764b1c
commit 825c70c001
30 changed files with 246 additions and 191 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
sources/application/UI/Component/QuickCreate/QuickCreate.php
View File

@@ -62,7 +62,7 @@ class QuickCreate extends UIBlock
* @throws \CoreException
* @throws \DictExceptionMissingString
*/
public function __construct($aLastClasses = [], $sId = null)
public function __construct(array $aLastClasses = [], ?string $sId = null)
{
parent::__construct($sId);
$this->aAvailableClasses = UserRights::GetAllowedClasses(UR_ACTION_CREATE, array('bizmodel'), true);
@@ -86,9 +86,10 @@ class QuickCreate extends UIBlock
*
* @return $this
*/
public function SetLastClasses($aLastClasses)
public function SetLastClasses(array $aLastClasses)
{
$this->aLastClasses = $aLastClasses;
return $this;
}

8
sources/application/UI/Component/QuickCreate/QuickCreateHelper.php
View File

@@ -49,19 +49,19 @@ class QuickCreateHelper
* @throws \MySQLException
* @throws \Exception
*/
public static function AddClassToHistory($Class)
public static function AddClassToHistory($sClass)
{
$aNewEntry = [
'class' => $Class,
'class' => $sClass,
];
/** @var array $aHistoryEntries */
$aHistoryEntries = appUserPreferences::GetPref(static::USER_PREF_CODE, []);
// Remove same entry from history to avoid duplicates
for($iIdx = 0; $iIdx < count($aHistoryEntries); $iIdx++)
for ($iIdx = 0; $iIdx < count($aHistoryEntries); $iIdx++)
{
if($aHistoryEntries[$iIdx]['class'] === $Class)
if ($aHistoryEntries[$iIdx]['class'] === $sClass)
{
unset($aHistoryEntries[$iIdx]);
}