From 7b95d65f60ad738fd85aad1f3188aa42e636f81b Mon Sep 17 00:00:00 2001
From: Anne-Cath <anne-catherine.cognet@combodo.com>
Date: Fri, 1 Aug 2025 10:05:23 +0200
Subject: [PATCH] =?UTF-8?q?N=C2=B03653=20-=20Remove=20parameter=20for=20\D?=
 =?UTF-8?q?BObjectSearch::GetQueryParams?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 core/dbobjectsearch.class.php | 57 +++++++++++++++++------------------
 core/dbsearch.class.php       |  4 +--
 core/dbunionsearch.class.php  |  4 +--
 3 files changed, 30 insertions(+), 35 deletions(-)

diff --git a/core/dbobjectsearch.class.php b/core/dbobjectsearch.class.php
index 46e2a393d..5f3ca1047 100644
--- a/core/dbobjectsearch.class.php
+++ b/core/dbobjectsearch.class.php
@@ -1373,44 +1373,41 @@ class DBObjectSearch extends DBSearch
 		$this->m_aParams[$sKey] = $value;
 	}
 
-	public function GetQueryParams($bExcludeMagicParams = true)
+	public function GetQueryParams()
 	{
 		$aParams = array();
 		$this->m_oSearchCondition->RenderExpression(false, $aParams, true);
 
-		if ($bExcludeMagicParams)
-		{
-			$aRet = array();
+		$aRet = array();
 
-			// Make the list of acceptable arguments... could be factorized with run_query, into oSearch->GetQueryParams($bExclude magic params)
-			$aNakedMagicArguments = array();
-			foreach (MetaModel::PrepareQueryArguments(array(),array(), $this->GetExpectedArguments()) as $sArgName => $value)
+		// Make the list of acceptable arguments... could be factorized with run_query, into oSearch->GetQueryParams()
+		$aNakedMagicArguments = array();
+		foreach (MetaModel::PrepareQueryArguments(array(),array(), $this->GetExpectedArguments()) as $sArgName => $value)
+		{
+			$iPos = strpos($sArgName, '->object()');
+			if ($iPos === false)
 			{
-				$iPos = strpos($sArgName, '->object()');
-				if ($iPos === false)
-				{
-					$aNakedMagicArguments[$sArgName] = $value;
-				}
-				else
-				{
-					$aNakedMagicArguments[substr($sArgName, 0, $iPos)] = true;
-				}
+				$aNakedMagicArguments[$sArgName] = $value;
 			}
-			foreach ($aParams as $sParam => $foo)
+			else
 			{
-				$iPos = strpos($sParam, '->');
-				if ($iPos === false)
-				{
-					$sRefName = $sParam;
-				}
-				else
-				{
-					$sRefName = substr($sParam, 0, $iPos);
-				}
-				if (!array_key_exists($sRefName, $aNakedMagicArguments))
-				{
-					$aRet[$sParam] = $foo;
-				}
+				$aNakedMagicArguments[substr($sArgName, 0, $iPos)] = true;
+			}
+		}
+		foreach ($aParams as $sParam => $foo)
+		{
+			$iPos = strpos($sParam, '->');
+			if ($iPos === false)
+			{
+				$sRefName = $sParam;
+			}
+			else
+			{
+				$sRefName = substr($sParam, 0, $iPos);
+			}
+			if (!array_key_exists($sRefName, $aNakedMagicArguments))
+			{
+				$aRet[$sParam] = $foo;
 			}
 		}
 
diff --git a/core/dbsearch.class.php b/core/dbsearch.class.php
index 3c30c3e10..ce37cf886 100644
--- a/core/dbsearch.class.php
+++ b/core/dbsearch.class.php
@@ -533,11 +533,9 @@ abstract class DBSearch
     /**
      * @internal
      *
-     * @param bool $bExcludeMagicParams
-     *
      * @return mixed
      */
-	abstract public function GetQueryParams($bExcludeMagicParams = true);
+	abstract public function GetQueryParams();
 
     /**
      * @internal
diff --git a/core/dbunionsearch.class.php b/core/dbunionsearch.class.php
index 7f4b16d6b..bd2336936 100644
--- a/core/dbunionsearch.class.php
+++ b/core/dbunionsearch.class.php
@@ -479,12 +479,12 @@ class DBUnionSearch extends DBSearch
 		return $aParams;
 	}
 
-	public function GetQueryParams($bExcludeMagicParams = true)
+	public function GetQueryParams()
 	{
 		$aParams = array();
 		foreach ($this->aSearches as $oSearch)
 		{
-			$aParams = array_merge($oSearch->GetQueryParams($bExcludeMagicParams), $aParams);
+			$aParams = array_merge($oSearch->GetQueryParams(), $aParams);
 		}
 		return $aParams;
 	}