From 7a40db94fb4e889267474a3fe953c49b297f2de0 Mon Sep 17 00:00:00 2001
From: bruno DA SILVA <bruno.dasilva@combodo.com>
Date: Mon, 4 May 2020 12:00:30 +0200
Subject: [PATCH] 2424 - Better messages when an object update fail & removed
 an unwanted webserver error log entry

---
 pages/UI.php | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/pages/UI.php b/pages/UI.php
index 7bf8491e84..b84d3aa47d 100644
--- a/pages/UI.php
+++ b/pages/UI.php
@@ -921,10 +921,13 @@ HTML
 			}
 			elseif (!utils::IsTransactionValid($sTransactionId, false))
 			{
+				//TODO: since $bDisplayDetails= true, there will be an redirection, thus, the content generated here is ignored, only the $sMessage and $sSeverity are used afeter the redirection 
 				$sUser = UserRights::GetUser();
 				IssueLog::Error("UI.php '$operation' : invalid transaction_id ! data: user='$sUser', class='$sClass'");
 				$oP->set_title(Dict::Format('UI:ModificationPageTitle_Object_Class', $oObj->GetRawName(), $sClassLabel)); // Set title will take care of the encoding
 				$oP->p("<strong>".Dict::S('UI:Error:ObjectAlreadyUpdated')."</strong>\n");
+				$sMessage = Dict::Format('UI:Error:ObjectAlreadyUpdated', MetaModel::GetName(get_class($oObj)), $oObj->GetName());
+				$sSeverity = 'error';
 			}
 			else
 			{
@@ -988,6 +991,8 @@ HTML
 				else
 				{
 					// Nothing more to do
+					$sMessage = isset($sMessage) ? $sMessage : '';
+					$sSeverity = isset($sSeverity) ? $sSeverity : null;
 					ReloadAndDisplay($oP, $oObj, 'update', $sMessage, $sSeverity);
 				}