composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-05-19 15:22:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

#953 Protect the background processing against corrupted (incomplete) objects.

Browse Source 
SVN:2.0.2[3232]
This commit is contained in:
Denis Flaven
2014-06-30 15:26:22 +00:00
parent 1ccb78276a
commit 78d211132d
1 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
core/asynctask.class.inc.php
View File

@@ -40,8 +40,24 @@ class ExecAsyncTask implements iBackgroundProcess
$iProcessed = 0; $iProcessed = 0;
while ((time() < $iTimeLimit) && ($oTask = $oSet->Fetch())) while ((time() < $iTimeLimit) && ($oTask = $oSet->Fetch()))
{ {
$oTask->Set('started', time()); try
$oTask->DBUpdate(); {
$oTask->Set('started', time());
$oTask->DBUpdate();
}
catch(Exception $e)
{
// Corrupted task !! (for example: "Failed to reload object")
IssueLog::Error('Failed to process async task #'.$oTask->GetKey().' - reason: '.$e->getMessage().' - fatal error, deleting the task.');
if ($oTask->Get('event_id') != 0)
{
$oEventLog = MetaModel::GetObject('Event', $oTask->Get('event_id'));
$oEventLog->Set('message', 'Failed, corrupted data: '.$e->getMessage());
$oEventLog->DBUpdate();
}
$oTask->DBDelete();
continue; // end of processing for this task
}
try try
{ {