diff --git a/core/sqlobjectquerybuilder.class.inc.php b/core/sqlobjectquerybuilder.class.inc.php index 48416f22c..ce5e82b20 100644 --- a/core/sqlobjectquerybuilder.class.inc.php +++ b/core/sqlobjectquerybuilder.class.inc.php @@ -102,6 +102,18 @@ class SQLObjectQueryBuilder return $oOQLClassNode; } + /** + * + * @param \QueryBuilderContext $oBuild The builder will be unusable after that + * + * @return string + * @throws \CoreException + */ + public function DebugOQLClassTree($oBuild) + { + return $this->GetOQLClassTree($oBuild)->RenderDebug(); + } + /** * @param \QueryBuilderContext $oBuild @@ -264,12 +276,8 @@ class SQLObjectQueryBuilder { if (!$oBuild->GetRootFilter()->GetArchiveMode()) { - $bIsOnJoinedClass = array_key_exists($sClassAlias, $oBuild->GetRootFilter()->GetJoinedClasses()); - if ($bIsOnJoinedClass) - { - $oNotArchived = new BinaryExpression(new FieldExpressionResolved('archive_flag', $sClassAlias), '=', new ScalarExpression(0)); - $oBuild->AddFilteredTable($sClassAlias, $oNotArchived); - } + $oNotArchived = new BinaryExpression(new FieldExpressionResolved('archive_flag', $sClassAlias), '=', new ScalarExpression(0)); + $oBuild->AddFilteredTable($sClassAlias, $oNotArchived); } } @@ -288,4 +296,4 @@ class SQLObjectQueryBuilder return $oBaseSQLQuery; } -} \ No newline at end of file +} diff --git a/pages/ajax.searchform.php b/pages/ajax.searchform.php index 19708f2ef..2593c9fbb 100644 --- a/pages/ajax.searchform.php +++ b/pages/ajax.searchform.php @@ -119,7 +119,7 @@ try } - if (isset($aListParams['debug']) || (UserRights::IsActionAllowed('ResourceRunQueriesMenu', UR_ACTION_MODIFY) == UR_ALLOWED_YES)) + if (isset($aListParams['debug']) || UserRights::IsAdministrator()) { $oPage->StartCollapsibleSection(Dict::S('UI:RunQuery:MoreInfo'), false, 'SearchQuery'); $oPage->p(Dict::S('UI:RunQuery:DevelopedQuery').htmlentities($oFilter->ToOQL(), ENT_QUOTES, 'UTF-8')); diff --git a/test/VerifyOQL.php b/test/VerifyOQL.php new file mode 100644 index 000000000..af0674453 --- /dev/null +++ b/test/VerifyOQL.php @@ -0,0 +1,288 @@ + array( + "Web applications" => "SELECT WebApplication", + "Person having an 'A' in their name" => "SELECT Person AS B WHERE B.name LIKE '%A%'", + "Servers having a name like dbserver1.demo.com or dbserver023.foo.fr" => "SELECT Server WHERE name REGEXP '^dbserver[0-9]+\\\\..+\\\\.[a-z]{2,3}$'", + "Changes planned on new year's day" => "SELECT Change AS ch WHERE ch.start_date >= '2009-12-31' AND ch.end_date <= '2010-01-01'", + "IPs in a range" => "SELECT DatacenterDevice AS dev WHERE INET_ATON(dev.managementip) > INET_ATON('10.22.32.224') AND INET_ATON(dev.managementip) < INET_ATON('10.22.32.255')", + "Persons below a given root organization" => "SELECT Person AS P JOIN Organization AS Node ON P.org_id = Node.id JOIN Organization AS Root ON Node.parent_id BELOW Root.id WHERE Root.id=1", + ), + 'Usefull examples' => array( + "NW interfaces of equipment in production for customer 'Demo'" => "SELECT PhysicalInterface AS if JOIN DatacenterDevice AS dev ON if.connectableci_id = dev.id WHERE dev.status = 'production' AND dev.organization_name = 'Demo'", + "My tickets" => "SELECT Ticket AS t WHERE t.agent_id = :current_contact_id", + "People being owner of an active ticket" => "SELECT Person AS p JOIN UserRequest AS u ON u.agent_id = p.id WHERE u.status != 'closed'", + "Contracts terminating in the next thirty days" => "SELECT Contract AS c WHERE c.end_date > NOW() AND c.end_date < DATE_ADD(NOW(), INTERVAL 30 DAY)", + "Orphan tickets (opened one hour ago, still not assigned)" => "SELECT UserRequest AS u WHERE u.start_date < DATE_SUB(NOW(), INTERVAL 60 MINUTE) AND u.status = 'new'", + "Long lasting incidents (duration > 8 hours)" => "SELECT UserRequest AS u WHERE u.close_date > DATE_ADD(u.start_date, INTERVAL 8 HOUR)", + ), + ); + + $aDisplayData = array(); + $oAppContext = new ApplicationContext(); + $sContext = $oAppContext->GetForForm(); + foreach ($aExamples as $sTopic => $aQueries) + { + foreach ($aQueries as $sDescription => $sOql) + { + $sHighlight = ''; + $sDisable = ''; + if ($sOql == $sExpression) + { + // this one is currently being tested, highlight it + $sHighlight = "background-color:yellow;"; + $sDisable = 'disabled'; + // and remember we are testing a query of the list + $bUsingExample = true; + } + //$aDisplayData[$sTopic][] = array( + $aDisplayData[Dict::S('UI:RunQuery:QueryExamples')][] = array( + 'desc' => "
'.$oFilter->ToOQL().''); + $oP->EndCollapsibleSection(); + + $aModifierProperties = MetaModel::MakeModifierProperties($oFilter); + + $oP->StartCollapsibleSection('OQL Developed'); + $oSQLObjectQueryBuilder = new SQLObjectQueryBuilder($oFilter); + $oBuild = new QueryBuilderContext($oFilter, $aModifierProperties); + $oP->p('
'.$oSQLObjectQueryBuilder->DebugOQLClassTree($oBuild).''); + $oP->EndCollapsibleSection(); + + $oP->StartCollapsibleSection('SQL Count'); + $oSQLObjectQueryBuilder = new SQLObjectQueryBuilder($oFilter); + $oBuild = new QueryBuilderContext($oFilter, $aModifierProperties); + $oSQLQueryCount = $oSQLObjectQueryBuilder->BuildSQLQueryStruct(null, true, $aModifierProperties); + $oP->p('
'.$oSQLQueryCount->RenderSelect(array(), array(), 0, 0, true, true).''); + $oP->EndCollapsibleSection(); + + $oP->StartCollapsibleSection('SQL'); + $oSQLObjectQueryBuilder = new SQLObjectQueryBuilder($oFilter); + $oBuild = new QueryBuilderContext($oFilter, $aModifierProperties); + $oSQLQuery = $oSQLObjectQueryBuilder->BuildSQLQueryStruct(null, false, $aModifierProperties); + $oP->p('
'.$oSQLQuery->RenderSelect(array(), array(), 10, 0, false, true).''); + $oP->EndCollapsibleSection(); + + } + elseif ($sSyntaxError) + { + if ($e instanceof OqlException) + { + $sWrongWord = $e->GetWrongWord(); + $aSuggestedWords = $e->GetSuggestions(); + if (count($aSuggestedWords) > 0) + { + $sSuggestedWord = OqlException::FindClosestString($sWrongWord, $aSuggestedWords); + + if (strlen($sSuggestedWord) > 0) + { + $oP->p(''.Dict::Format('UI:RunQuery:Error', $e->GetIssue().' '.$sWrongWord).''); + $sBefore = substr($sExpression, 0, $e->GetColumn()); + $sAfter = substr($sExpression, $e->GetColumn() + strlen($sWrongWord)); + $sFixedExpression = $sBefore.$sSuggestedWord.$sAfter; + $sFixedExpressionHtml = $sBefore.''.$sSuggestedWord.''.$sAfter; + $oP->p("Suggesting: $sFixedExpressionHtml"); + $oP->add(''); + } + else + { + $oP->p(''.Dict::Format('UI:RunQuery:Error', $e->getHtmlDesc()).''); + } + } + else + { + $oP->p(''.Dict::Format('UI:RunQuery:Error', $e->getHtmlDesc()).''); + } + } + else + { + $oP->p(''.Dict::Format('UI:RunQuery:Error', $e->getMessage()).''); + } + } +} catch (Exception $e) +{ + $oP->p(''.Dict::Format('UI:RunQuery:Error', $e->getMessage()).''); +} + +$oP->output(); +