composer/iTop
6
0
Fork 0
mirror of https://github.com/Combodo/iTop.git synced 2026-04-23 10:38:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

N°5655 - Switch backoffice controllers' methods to non-static and now extend an abstract controller

Browse Source
This commit is contained in:
Molkobain
2022-11-04 11:37:46 +01:00
parent 36ec455e6d
commit 73139e82cb
13 changed files with 75 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
sources/Controller/AbstractController.php Normal file
View File

@@ -0,0 +1,21 @@
<?php
/*
* @copyright Copyright (C) 2010-2022 Combodo SARL
* @license http://opensource.org/licenses/AGPL-3.0
*/
namespace Combodo\iTop\Controller;
/**
* Class AbstractController
*
* Abstract controller to centralize common features of business controllers which are still to be defined.
*
* @author Guillaume Lajarige <guillaume.lajarige@combodo.com>
* @package Combodo\iTop\Controller
* @since 3.1.0
*/
class AbstractController
{
// Empty stub for now, factorized needs might come later
}

9
sources/Controller/Base/Layout/ActivityPanelController.php
View File

@@ -8,6 +8,7 @@ namespace Combodo\iTop\Controller\Base\Layout;
use Combodo\iTop\Application\UI\Base\Layout\ActivityPanel\ActivityEntry\ActivityEntryFactory;
use Combodo\iTop\Application\UI\Base\Layout\ActivityPanel\ActivityPanelHelper;
use Combodo\iTop\Controller\AbstractController;
use Combodo\iTop\Renderer\BlockRenderer;
use Dict;
use Exception;
@@ -23,14 +24,14 @@ use utils;
* @since 3.0.0
* @package Combodo\iTop\Controller\Base\Layout
*/
class ActivityPanelController
class ActivityPanelController extends AbstractController
{
/**
* @throws \CoreException
* @throws \CoreUnexpectedValue
* @throws \MySQLException
*/
public static function SaveState(): void
public function SaveState(): void
{
$sObjectClass = utils::ReadPostedParam('object_class', '', utils::ENUM_SANITIZATION_FILTER_CLASS);
$sObjectMode = utils::ReadPostedParam('object_mode');
@@ -74,7 +75,7 @@ class ActivityPanelController
* @throws \Twig\Error\RuntimeError
* @throws \Twig\Error\SyntaxError
*/
public static function AddCaseLogsEntries(): array
public function AddCaseLogsEntries(): array
{
$sObjectClass = utils::ReadPostedParam('object_class', null, utils::ENUM_SANITIZATION_FILTER_CLASS);
$sObjectId = utils::ReadPostedParam('object_id', 0);
@@ -154,7 +155,7 @@ class ActivityPanelController
* @throws \Twig\Error\RuntimeError
* @throws \Twig\Error\SyntaxError
*/
public static function LoadMoreEntries(): array
public function LoadMoreEntries(): array
{
$sObjectClass = utils::ReadPostedParam('object_class', null, utils::ENUM_SANITIZATION_FILTER_CLASS);
$sObjectId = utils::ReadPostedParam('object_id', 0);

4
sources/Controller/PreferencesController.php
View File

@@ -22,7 +22,7 @@ use utils;
* @since 3.0.0
* @package Combodo\iTop\Controller
*/
class PreferencesController
class PreferencesController extends AbstractController
{
/**
* @return string[]
@@ -31,7 +31,7 @@ class PreferencesController
* @throws \MySQLException
* @throws \Exception
*/
public static function SetUserPicture(): array
public function SetUserPicture(): array
{
$sImageFilename = utils::ReadPostedParam('image_filename', null, utils::ENUM_SANITIZATION_FILTER_RAW_DATA);